Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1635] Improvement: Replace ColumnDTO with ColumnImpl in test cases #2487

Merged
merged 2 commits into from
Mar 11, 2024
Merged

[#1635] Improvement: Replace ColumnDTO with ColumnImpl in test cases #2487

merged 2 commits into from
Mar 11, 2024

Conversation

zivali
Copy link
Contributor

@zivali zivali commented Mar 9, 2024 •
edited
Loading

What changes were proposed in this pull request?

  • Use ColumnImpl instead of ColumnDTO when calling gravitino API in test cases.
  • Rename variable columnDTOs to columns to avoid misunderstanding.

Why are the changes needed?

Fix: #1635

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing integration tests.

mchades
mchades approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Your work on ColumnDTO usage is impressive and sets a benchmark for future contributions.

jerryshao
jerryshao approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zivali for your contribution.

@jerryshao jerryshao merged commit c74841c into apache:main Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchades mchades mchades approved these changes

@jerryshao jerryshao jerryshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] Replace ColumnDTO with ColumnImpl in test cases
3 participants
@zivali @jerryshao @mchades