Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix(lakehouse-iceberg): Fix the include core-site conf file name for lakehouse-iceberg gradle script #2430

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

xloya
Copy link
Contributor

@xloya xloya commented Mar 5, 2024

What changes were proposed in this pull request?

Fix include correct name to be core-site.xml.template instead of hive-site.xml.template.

@xloya xloya closed this Mar 5, 2024
@xloya xloya reopened this Mar 5, 2024
@jerryshao jerryshao requested a review from FANNG1 March 5, 2024 08:25
@FANNG1
Copy link
Contributor

FANNG1 commented Mar 5, 2024

LGTM

@FANNG1 FANNG1 changed the title fix(lakehouse-iceberg): Fix the include core-site conf file name for lakehouse-iceberg gradle script [MINOR] fix(lakehouse-iceberg): Fix the include core-site conf file name for lakehouse-iceberg gradle script Mar 5, 2024
@FANNG1 FANNG1 merged commit 3b700b4 into apache:main Mar 5, 2024
19 of 22 checks passed
@FANNG1
Copy link
Contributor

FANNG1 commented Mar 5, 2024

@xloya thanks for your work!

@jerryshao
Copy link
Contributor

@xloya can you please submit a same PR against branch-0.4?

@xloya xloya deleted the fix-iceberg-conf-copy branch June 20, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants