-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2084] feat(core): Add JDBC backend operations for fileset #2389
Conversation
@jerryshao @yuqi1129 @qqqttt123 This PR is also ready for reviews, please take a look when you have time! |
core/src/main/java/com/datastrato/gravitino/storage/relational/utils/POConverters.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/utils/POConverters.java
Show resolved
Hide resolved
I'm okay with the current changes. |
@jerryshao @qqqttt123 Do you have some comments for this PR? Thanks. |
LGTM except for some questions. |
core/src/main/java/com/datastrato/gravitino/storage/relational/utils/ExceptionUtils.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/FilesetMetaService.java
Show resolved
Hide resolved
I have no further comment, overall LGTM. One follow-up thing we should do is to enable end 2 end test for relational entity store, otherwise it is hard to tell if it works as expected. @xloya can you please do it as a follow-up work? |
Okay, I will add end-to-end testing of this piece soon. |
I have no further suggestion. |
LGTM, I'm going to merge it. |
What changes were proposed in this pull request?
The purpose of this PR is to implement JDBC backend operation for Fileset metadata. Depend on #2384.
Why are the changes needed?
Fix: #2084
How was this patch tested?
Add unit tests to test the fileset metadata ops.