[#1759] feat(TableChange) : TableChange support index. #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearvive
force-pushed
the
1759/add-index-change
branch
from
08b2394 to
b2592af
Compare
Clearvive
force-pushed
the
1759/add-index-change
branch
from
023b8fd to
b6d4049
Compare
yuqi1129
reviewed
Feb 27, 2024
...in/java/com/datastrato/gravitino/catalog/postgresql/operation/PostgreSqlTableOperations.java
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/datastrato/gravitino/rel/TableChange.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Feb 27, 2024
api/src/main/java/com/datastrato/gravitino/rel/TableChange.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/com/datastrato/gravitino/catalog/mysql/operation/MysqlTableOperations.java
Show resolved
Hide resolved
|
@Clearvive, does this pull request support |
This PR does not support AlterIndex. Currently, not all metadata supports modifying index information. Users can perform operations by first deleting and then creating anew. I will now modify the description of this issue accordingly. |
Clearvive
force-pushed
the
1759/add-index-change
branch
from
416de74 to
4094332
Compare
Clearvive
force-pushed
the
1759/add-index-change
branch
from
b59eda9 to
c38bca0
Compare
yuqi1129
previously approved these changes
Feb 28, 2024
FANNG1
reviewed
Feb 28, 2024
server/src/test/java/com/datastrato/gravitino/server/web/rest/TestTableOperations.java
Outdated
Show resolved
Hide resolved
|
LGTM except the minor comments |
FANNG1
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TableChange support index.
The current PR does not support the extension of
AlterIndex.Currently, only
AddIndexandDeleteIndexare supported.Why are the changes needed?
Fix: #1759
Does this PR introduce any user-facing change?
Add Index TableChange
How was this patch tested?
IT,UT