-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2099] fix(web): redirect to login page if token has expired #2312
Conversation
There's another solution. if the token is expired and returns 401, we can redirect to the login page to ask users to re-login. WDYT @qqqttt123 ? |
This may affect the experience of users. |
Yeah, but it is a common way as far as I know. We cannot renew the token forever, it is not safe. |
OK, it's also acceptable. |
@ch3yne Can you please update the codes to the logic we mentioned above? |
Done. |
@LauraXia123 Please help review this PR, thanks! |
|
||
Router().push('/ui/login') | ||
window.location.href = '/ui/login' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ch3yne would you please update the PR title and description? The current change is not about refreshing the token any more. |
Done |
### What changes were proposed in this pull request? Remove refresh token and redirect to login page if token has expired. ### Why are the changes needed? Fix: #2099 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
What changes were proposed in this pull request?
Remove refresh token and redirect to login page if token has expired.
Why are the changes needed?
Fix: #2099
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A