[#1735] fix(web): fix sorting and filtering of the metalakes table #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Feb 22, 2024
web/app/ui/MetalakeList.js
Outdated
| @@ -26,7 +26,7 @@ function TableToolbar(props) { | |||
| <> | |||
| <Fragment> | |||
| <Portal container={() => document.getElementById('filter-panel')}> | |||
| <Box className={`twc-w-full twc-justify-between twc-hidden`}> | |||
| <Box className={` twc-flex twc-w-full twc-justify-between`}> | |||
There was a problem hiding this comment.
What is the purpose of adding a white space before "twc-flex"? Is it by mistaken or added deliberately?
There was a problem hiding this comment.
My mistake, I'll fix it.
jerryshao
added
need backport
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
…2309) ### What changes were proposed in this pull request? Fix sorting and filtering of the metalakes table. <img width="1023" alt="image" src="https://github.com/datastrato/gravitino/assets/17310559/3ade8070-c24d-45f5-a43b-fd693c7d0234"> ### Why are the changes needed? Fix: #1735 Fix: #2072 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix sorting and filtering of the metalakes table.
Why are the changes needed?
Fix: #1735
Fix: #2072
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A