Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2155] fix: add missing @return #2228

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

FrankYang0529
Copy link
Member

What changes were proposed in this pull request?

@return missing description in:
JdbcDatabaseOperations.java
ConvertUtil.java
FromIcebergPartitionSpec.java
ToIcebergPartitionSpec.java
IcebergTableOpsHelper.java
JsonUtils.java
TrinoQueryIT.java

Why are the changes needed?

For better document.

Fix: #2155

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Make sure there is no missing description for @return.

Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for doing this.

@justinmclean justinmclean merged commit c9d9f36 into apache:main Feb 18, 2024
12 checks passed
@FrankYang0529 FrankYang0529 deleted the GRAVITINO-2155 branch February 19, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Fill in misisng Javadoc for @return
2 participants