Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] docs(lakehouse-iceberg): polish iceberg document #2040

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Feb 4, 2024

What changes were proposed in this pull request?

  1. remove gravitino.auxService.iceberg-rest.jdbc-driver not required message
  2. polish catalog to catalog backend to make it more clear.
  3. remove struct from the Iceberg catalogs support types

Why are the changes needed?

polish iceberg rest catalog document

Does this PR introduce any user-facing change?

no

How was this patch tested?

just document

@FANNG1 FANNG1 changed the title [MINOR] docs(lakehouse-iceberg): polish iceberg rest catalog document [MINOR] docs(lakehouse-iceberg): polish iceberg document Feb 4, 2024
@jerryshao jerryshao added need backport Issues that need to backport to another branch branch-0.4 labels Feb 4, 2024
@@ -74,7 +74,7 @@ Gravitino provides a pluggable metrics store interface to store and delete Icebe
### Gravitino Iceberg catalog backend configuration

:::info
The Gravitino Iceberg REST catalog service uses the memory catalog by default. You can specify using a Hive or JDBC catalog in a production environment.
The Gravitino Iceberg REST catalog service uses the memory by default catalog backend. You can specify using a Hive or JDBC catalog backend in a production environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing whitespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was no whitespace after production environment.

@jerryshao jerryshao requested a review from qqqttt123 February 4, 2024 12:04
@jerryshao jerryshao merged commit 941eeeb into apache:main Feb 4, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
### What changes were proposed in this pull request?
1. remove `gravitino.auxService.iceberg-rest.jdbc-driver` not required
message
2. polish catalog to catalog backend to make it more clear.
3. remove `struct` from the Iceberg catalogs support types

### Why are the changes needed?

polish iceberg rest catalog document


### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
just document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants