[#2034] Improvement (trino-connector): Add datatype , catalog test cases for the Trino connector #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add postgresql catalog for tcpds testset increase trino jvm heap size
Make TrinoQueryIT only run basic testset and tcph testset
Add help message for TrinoQueryTestTool
|
@yuqi1129 can you please review this? |
yuqi1129
reviewed
Feb 5, 2024
|
|
||
| INSERT: 1 row | ||
|
|
||
| "Sample text 1","Text1 ","65","123.456","7.89","12.34","false","1","100","1000","1000","100000","2024-01-01","2024-01-01 08:00:00.000" |
There was a problem hiding this comment.
A question about space in value: Do you write it deliberately?
There was a problem hiding this comment.
The field f2 is defined as CHAR(20), so it is filled with spaces if the input is shorter than 20 characters.”
|
Others seem to be okay with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add datatype , catalog test cases for the Trino connector
Why are the changes needed?
Issue: #2034
Does this PR introduce any user-facing change?
NO
How was this patch tested?
TriniQueryIT