Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] merge branch-spark-connector-dev to main #1888

Closed
wants to merge 1 commit into from

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Feb 2, 2024

What changes were proposed in this pull request?

merge branch-spark-connector-dev to main

Why are the changes needed?

continue spark-connector development on main

Does this PR introduce any user-facing change? no

no

How was this patch tested?

existing UTs

…ild and test Gravitino (#1582)

### What changes were proposed in this pull request?
support specify scala versions, by two methods:
1. `gradle build -PscalaVersion=xx`
2. set `defaultScalaVersion` in gradle.properties

method2 will be overwrite  by method1 if both existing, 
and supports scala 2.12 for now.

### Why are the changes needed?
spark hive connector just supports scala 2.12

Fix: #1530 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing UTs
@FANNG1 FANNG1 marked this pull request as draft February 2, 2024 03:50
@FANNG1 FANNG1 changed the title [#1530] feat(spark-connector): support specifying scala version to bu… [MINOR] merge branch-spark-connector-dev to main Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Code Coverage Report

Overall Project 61.97% 🟢

There is no coverage information present for the Files changed

@FANNG1 FANNG1 marked this pull request as ready for review February 2, 2024 09:40
@FANNG1 FANNG1 requested review from jerryshao and qqqttt123 February 7, 2024 01:51
@FANNG1
Copy link
Contributor Author

FANNG1 commented Feb 7, 2024

@jerryshao @qqqttt123 could we merge it now?

@qqqttt123
Copy link
Contributor

What changes were proposed in this pull request? Just modified some dependencies?

@FANNG1
Copy link
Contributor Author

FANNG1 commented Feb 7, 2024

What changes were proposed in this pull request? Just modified some dependencies?

only include #1582

Copy link
Contributor

@qqqttt123 qqqttt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qqqttt123
Copy link
Contributor

Could you modify the title and description of pull request?

@FANNG1 FANNG1 closed this Feb 7, 2024
@jerryshao jerryshao deleted the branch-spark-connector-dev branch July 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants