[#1769] feat(partition): Support listPartitions for Hive catalog
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mchades can you please fix the conflicts. |
jerryshao
reviewed
Jan 31, 2024
| @@ -50,15 +53,21 @@ public Response listPartitionNames( | |||
| @PathParam("metalake") String metalake, | |||
| @PathParam("catalog") String catalog, | |||
| @PathParam("schema") String schema, | |||
| @PathParam("table") String table) { | |||
| @PathParam("table") String table, | |||
| @QueryParam("verbose") @DefaultValue("false") boolean verbose) { | |||
There was a problem hiding this comment.
I would suggest to change the quey parameter to "details".
jerryshao
reviewed
Jan 31, 2024
| } else { | ||
| String[] partitionNames = loadTable.supportPartitions().listPartitionNames(); | ||
| return Utils.ok(new PartitionNameListResponse((partitionNames))); | ||
| } |
There was a problem hiding this comment.
Also I think you miss the UTs here.
jerryshao
reviewed
Jan 31, 2024
| @@ -211,6 +211,46 @@ public void testListPartitionNames() { | |||
| Assertions.assertTrue(errorResp2.getMessage().contains("test exception")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testListPartitions() { | |||
There was a problem hiding this comment.
Can you please add a test case returning empty partitions?
jerryshao
approved these changes
Jan 31, 2024
jerryshao
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
listPartitionsfor Hive catalogWhy are the changes needed?
Fix: #1769
Does this PR introduce any user-facing change?
no
How was this patch tested?
tests added