Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1774] feat(server): Add REST API for adding partition #1775

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

mchades
Copy link
Contributor

@mchades mchades commented Jan 30, 2024

What changes were proposed in this pull request?

Add REST API for adding partition

Why are the changes needed?

Fix: #1774

Does this PR introduce any user-facing change?

no

How was this patch tested?

UTs added

@mchades mchades self-assigned this Jan 30, 2024
@mchades mchades marked this pull request as ready for review January 30, 2024 08:31
@mchades mchades requested a review from jerryshao January 30, 2024 08:31
public void validate() throws IllegalArgumentException {
Preconditions.checkArgument(partitions != null, "partitions must not be null");
Preconditions.checkArgument(
partitions.length == 1, "Have not implemented multiple partitions yet");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Haven't yet"

@jerryshao jerryshao merged commit 4c1d7cc into apache:main Jan 30, 2024
12 checks passed
@mchades mchades deleted the add-par-1 branch November 22, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add REST API for adding partitions
2 participants