Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1079] improvement(CI): Modify the pipeline check logic in regards to code changes #1469

Merged
merged 3 commits into from
Jan 15, 2024
Merged

[#1079] improvement(CI): Modify the pipeline check logic in regards to code changes #1469

merged 3 commits into from
Jan 15, 2024

Conversation

qqqttt123
Copy link
Contributor

@qqqttt123 qqqttt123 commented Jan 12, 2024 •
edited
Loading

What changes were proposed in this pull request?

Modify the pipeline check logic in regards to code changes

Why are the changes needed?

Fix: #1079

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested by own repo. qqqttt123#3

@qqqttt123 qqqttt123 marked this pull request as draft January 12, 2024 11:27
@qqqttt123 qqqttt123 closed this Jan 12, 2024
@qqqttt123 qqqttt123 reopened this Jan 12, 2024
@qqqttt123 qqqttt123 marked this pull request as ready for review January 12, 2024 11:55
Heng Qin added 2 commits January 12, 2024 19:56
@qqqttt123 qqqttt123 changed the title [#1079] improvement(CI): Add doc to the lint check for Gravitino [#1079] improvement(CI): Add doc to the compile check for Gravitino Jan 12, 2024
@yuqi1129
Copy link
Contributor

This PR adds a check for source code changes so that the CI can determine whether to trigger the pipeline or not. Am I right?

Besides, the title ' Add doc to the', the doc is quite confusing...

@qqqttt123
Copy link
Contributor Author

This PR adds a check for source code changes so that the CI can determine whether to trigger the pipeline or not. Am I right?

Besides, the title ' Add doc to the', the doc is quite confusing...

Not exactly. If sources change, we will run the build job. Otherwise, we will run the compile-check job.

@qqqttt123
Copy link
Contributor Author

This PR adds a check for source code changes so that the CI can determine whether to trigger the pipeline or not. Am I right?

Besides, the title ' Add doc to the', the doc is quite confusing...

What's your suggestion?

@yuqi1129
Copy link
Contributor

Not exactly. If sources change, we will run the build job. Otherwise, we will run the compile-check job.

I'm not very clear about Otherwise, we will run the compile-check job, you means if the code has not changed, we will run compile-check job?

What's the difference between build and compile job?

@yuqi1129
Copy link
Contributor

What's your suggestion?

What about the title 'Modify the pipeline check logic in regards to code changes'?

@qqqttt123
Copy link
Contributor Author

Not exactly. If sources change, we will run the build job. Otherwise, we will run the compile-check job.

I'm not very clear about Otherwise, we will run the compile-check job, you means if the code has not changed, we will run compile-check job?

What's the difference between build and compile job?

Build job will run the tests. Compile job only run the rat check, lint check and compile the code.

@qqqttt123
Copy link
Contributor Author

What's your suggestion?

What about the title 'Modify the pipeline check logic in regards to code changes'?

ok.

@qqqttt123 qqqttt123 changed the title [#1079] improvement(CI): Add doc to the compile check for Gravitino [#1079] improvement(CI): Modify the pipeline check logic in regards to code changes Jan 12, 2024
justinmclean pushed a commit to justinmclean/gravitino that referenced this pull request Jan 15, 2024
@github-actions @ch3yne
[apache#1469] improvement(doc): Add doc about webUI operation (apache…
5477388 
…#1281)

### What changes were proposed in this pull request?

Compose documentation for the webUI, detailing the procedures for CRUD
operations.

### Why are the changes needed?

Fix: apache#1269 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <[email protected]>
yuqi1129
yuqi1129 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerryshao pushed a commit to jerryshao/gravitino that referenced this pull request Jan 15, 2024
@ch3yne
[apache#1469] improvement(doc): Add doc about webUI operation (apache…
886235a 
…#1270)

### What changes were proposed in this pull request?

Compose documentation for the webUI, detailing the procedures for CRUD
operations.

### Why are the changes needed?

Fix: apache#1269 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao merged commit ce1d1b8 into apache:main Jan 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi1129 yuqi1129 yuqi1129 approved these changes

@jerryshao jerryshao Awaiting requested review from jerryshao

@xunliu xunliu Awaiting requested review from xunliu

@FANNG1 FANNG1 Awaiting requested review from FANNG1

@diqiu50 diqiu50 Awaiting requested review from diqiu50

@mchades mchades Awaiting requested review from mchades

@Clearvive Clearvive Awaiting requested review from Clearvive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Add doc to the lint check for Gravitino
3 participants
@qqqttt123 @yuqi1129 @jerryshao