[#1405] Print warning message instead of failing the bootstrap when using Java prior 8u151 #1406
Conversation
…when using Java prior 8u151
|
Hi, @pan3793 thank you for your contribution! Can you provide a short message about why we should use |
|
The context indicates Java prior 8u151 has security issues. |
Exactly, for this reason, we disable JAVA that before 8u151. |
|
@yuqi1129 what's the principle of Gravitino to handle the security issues? For example, what if the user wants to use an EOL version HMS(has log4shell security issue) combined with Gravitino, Gravitino just rejects the connection? |
bin/common.sh
Outdated
| @@ -59,8 +59,7 @@ function check_java_version() { | |||
| # JDK 8u151 version fixed a number of security vulnerabilities and issues to improve system stability and security. | |||
| # https://www.oracle.com/java/technologies/javase/8u151-relnotes.html | |||
| if [ "$JVM_VERSION" -lt 8 ] || { [ "$JVM_VERSION" -eq 8 ] && [ "${jvmver#*_}" -lt 151 ]; } ; then | |||
There was a problem hiding this comment.
hi @pan3793 Thank you for your interest in the Gravitino project.
I think this condition needs split to be 2.
- JVM_VERSION must greater than 8, otherwise exit.
- If JVM_VERSION less than 8.151, then print warn message.
There was a problem hiding this comment.
thanks for checking, updated as suggested.
What changes were proposed in this pull request?
Print warning message instead of failing the bootstrap when using Java prior 8u151
Why are the changes needed?
Fix: #1405
Does this PR introduce any user-facing change?
Yes, users who want to use Java prior 8u151 to bootstrap Gravitino just get an warning message instead of failing.
How was this patch tested?
Manually review