[#1398] feat(table): Add index api for tables. #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearvive
force-pushed
the
1398/add-index-to-user
branch
from
9adb618 to
9614ffd
Compare
|
I suggest adding some UT for the catalog that supports Index like MySQL catalog. |
yuqi1129
reviewed
Jan 9, 2024
api/src/main/java/com/datastrato/gravitino/rel/expressions/Indexes/Index.java
Outdated
Show resolved
Hide resolved
...g-jdbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/JdbcCatalogOperations.java
Outdated
Show resolved
Hide resolved
This is just a pull request for the API interface, which will be submitted in another PR |
Clearvive
changed the title
Clearvive
changed the title
|
@jerryshao Can you help me review it? |
|
@mchades At present, except for the complex index design of hive3.0, it is not considered to be supported in this issue. The current interface can support common systems. Do you have any suggestions? Can you help review it? |
|
please paste the design document |
mchades
reviewed
Jan 18, 2024
api/src/main/java/com/datastrato/gravitino/rel/expressions/Indexes/Index.java
Outdated
Show resolved
Hide resolved
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 18, 2024
...c/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java
Outdated
Show resolved
Hide resolved
|
LGTM, except some minor comments |
jerryshao
reviewed
Jan 18, 2024
common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java
Show resolved
Hide resolved
jerryshao
reviewed
Jan 19, 2024
api/src/main/java/com/datastrato/gravitino/rel/TableCatalog.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 19, 2024
api/src/main/java/com/datastrato/gravitino/rel/TableCatalog.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 19, 2024
api/src/main/java/com/datastrato/gravitino/rel/expressions/Indexes/Index.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 19, 2024
api/src/main/java/com/datastrato/gravitino/rel/expressions/Indexes/Index.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 19, 2024
FANNG1
reviewed
Jan 19, 2024
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Show resolved
Hide resolved
jerryshao
reviewed
Jan 19, 2024
api/src/main/java/com/datastrato/gravitino/rel/indexes/Index.java
Outdated
Show resolved
Hide resolved
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/catalog/CatalogOperationDispatcher.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jan 22, 2024
api/src/main/java/com/datastrato/gravitino/rel/indexes/Index.java
Outdated
Show resolved
Hide resolved
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Show resolved
Hide resolved
common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/datastrato/gravitino/dto/requests/TableCreateRequest.java
Outdated
Show resolved
Hide resolved
Clearvive
force-pushed
the
1398/add-index-to-user
branch
from
517e797 to
137dd1a
Compare
mchades
reviewed
Jan 22, 2024
api/src/main/java/com/datastrato/gravitino/rel/indexes/Indexes.java
Outdated
Show resolved
Hide resolved
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Jan 22, 2024
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 22, 2024
FANNG1
reviewed
Jan 22, 2024
.../catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 22, 2024
...g-jdbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/JdbcCatalogOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 22, 2024
...c/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 22, 2024
|
LGTM except some minor comments. |
jerryshao
approved these changes
Jan 23, 2024
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jan 24, 2024
### What changes were proposed in this pull request? Provide the Index interface implementation of the Table to the user side ### Why are the changes needed? Fix: apache#1398 ### Does this PR introduce _any_ user-facing change? Add table index impl. ### How was this patch tested? NO --------- Co-authored-by: Clearvive <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide the Index interface implementation of the Table to the user side
Why are the changes needed?
Fix: #1398
Does this PR introduce any user-facing change?
Add table index impl.
How was this patch tested?
NO