Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1293] improvement(IT): Change to use api method instead of DTOs #1294

Merged
merged 2 commits into from
Jan 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix CI test error.
yuqi1129 committed Jan 2, 2024
commit 4cff08b41a4636b9ecb1daa9ceeee6670b32c2be
Original file line number Diff line number Diff line change
@@ -41,6 +41,8 @@
import com.datastrato.gravitino.rel.expressions.sorts.SortDirection;
import com.datastrato.gravitino.rel.expressions.sorts.SortOrder;
import com.datastrato.gravitino.rel.expressions.sorts.SortOrders;
import com.datastrato.gravitino.rel.expressions.transforms.Transform;
import com.datastrato.gravitino.rel.expressions.transforms.Transforms;
import com.datastrato.gravitino.rel.types.Types;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Maps;
@@ -640,18 +642,14 @@ void testPartitionAndSortOrderIcebergTable() {
ColumnDTO[] columns = createColumns();
String testTableName = GravitinoITUtils.genRandomName("test_table");
SortOrder[] sortOrders = {
SortOrders.of(
NamedReference.field(columns[0].name()),
SortDirection.DESCENDING,
NullOrdering.NULLS_FIRST),
SortOrders.of(
NamedReference.field(columns[2].name()),
SortDirection.DESCENDING,
NullOrdering.NULLS_FIRST)
SortOrders.ascending(NamedReference.field(columns[0].name())),
SortOrders.descending(NamedReference.field(columns[2].name()))
};
Partitioning[] partitioning = {
DayPartitioningDTO.of(columns[1].name()), IdentityPartitioningDTO.of(columns[2].name())

Transform[] partitioning = {
Transforms.day(columns[1].name()), Transforms.identity(columns[2].name())
};

catalog
.asTableCatalog()
.createTable(