[#1180] feat(CI): Enable CI to test multiple JDK versions #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can enable all the tests currently, and optimize to use daily tests to run against jdk11 or 17 if necessary. WDYT? |
yuqi1129
reviewed
Dec 20, 2023
gradle/libs.versions.toml
Outdated
| @@ -10,7 +10,7 @@ guava = "31.1-jre" | |||
| lombok = "1.18.20" | |||
| slf4j = "2.0.9" | |||
| log4j = "2.22.0" | |||
| jetty = "9.4.51.v20230217" | |||
| jetty = "9.4.53.v20231009" | |||
There was a problem hiding this comment.
Why did we update the jetty version?
There was a problem hiding this comment.
I can revert the version. I bumped the version to see if it can fix the JDK17 problem I met yesterday, seems unrelated.
There was a problem hiding this comment.
I can revert the version.
Would you revert the change here? If no modifications are made later, I will approve it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to support multiple JDKs in github CI.
Why are the changes needed?
Fix: #1180
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.