Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Setting the workflow depends #768

Closed
Tracked by #1335
xunliu opened this issue Nov 17, 2023 · 3 comments
Closed
Tracked by #1335

[Improvement] Setting the workflow depends #768

xunliu opened this issue Nov 17, 2023 · 3 comments
Assignees
@qqqttt123
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything
Milestone
Gravitino 0.4.0

Comments

@xunliu
Copy link
Member

xunliu commented Nov 17, 2023 •
edited
Loading

What would you like to be improved?

Currently, build.yml and integration-test.yml execute out of order.
Integration tests should be performed after the build is successful

How should we improve?

Setting the workflow depends:

  1. First, execute build.yml,
  2. When build workflow successed in the Github Action then execute Integration Test workflow.
@xunliu xunliu added the improvement Improvements on everything label Nov 17, 2023
@xunliu xunliu self-assigned this Nov 17, 2023
@FANNG1
Copy link
Contributor

FANNG1 commented Nov 17, 2023

As I know, integrate tests runs serially, we could make it parallelly.

@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Dec 14, 2023
@jerryshao
Copy link
Contributor

Besides, I think the performance of the CI machine is too bad, not sure if we can set up a CI by our own, using AWS EC2 or others to build a CI machine, I'm not sure if the price is lower or higher than the github CI.

xunliu added a commit to xunliu/gravitino that referenced this issue Dec 20, 2023
@xunliu
[apache#768] improvement(CI): Setting the workflow depends
9831cc7
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 20, 2023
@xunliu
Merge pull request #1 from xunliu/issue-768
a5183d6 
[apache#768] improvement(CI): Setting the workflow execution order
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 20, 2023
@xunliu
[apache#768] improvement(CI): Setting the workflow depends
4dfc0a8
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 20, 2023
@xunliu
[apache#768] improvement(CI): Setting the workflow depends (#2)
2d01037
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 21, 2023
@xunliu
[apache#768] improvement(CI): Setting the workflow depends
2fd3691
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 21, 2023
@xunliu
[apache#768] improvement(CI): Setting the workflow depends (#3)
17ba646
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 21, 2023
@xunliu
[apache#768] improvement(CI): Setting the workflow depends
45e18c5
@xunliu xunliu changed the title [Improvement] Optimize CI execution time in GitHub Action [Improvement] Setting the workflow depends Dec 21, 2023
@xunliu xunliu mentioned this issue Dec 21, 2023
Closed
@qqqttt123 qqqttt123 added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 5, 2024
@qqqttt123 qqqttt123 mentioned this issue Jan 5, 2024
Closed
12 tasks
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
345fadb
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
13a329d
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
678ab88
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
df3063f
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
ae0b3cf
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
c99c3ee
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
8efa3b4
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
a59ec39
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
87ac643
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
2ebbbe8
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
b5c5d13
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Jan 15, 2024
[apache#768] improvement(CI): Setting the workflow dependencies
f4ce940
@qqqttt123 qqqttt123 mentioned this issue Jan 15, 2024
Closed
@qqqttt123
Copy link
Contributor

After discussion, this optimization is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qqqttt123 qqqttt123

Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.4.0
4 participants
@jerryshao @xunliu @FANNG1 @qqqttt123