Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Incorrect description about "Revoke roles from a group" in document access-control.md #6069

Closed
LiuJun302 opened this issue Jan 2, 2025 · 3 comments · Fixed by #6189
Closed

[Improvement] Incorrect description about "Revoke roles from a group" in document access-control.md #6069

LiuJun302 opened this issue Jan 2, 2025 · 3 comments · Fixed by #6189
Assignees
@Abyss-lord
Labels
0.8.0 Release v0.8.0 improvement Improvements on everything

Comments

@LiuJun302
Copy link

What would you like to be improved?

The java-api of "Revoke roles from a group" is incorrect :
It supposed to be 'revokeRolesFromGroup' but found 'grantRolesToGroup'.
The doc of Revoke roles from a group

How should we improve?

Fix the incorrect description.
@LiuJun302 LiuJun302 added the improvement Improvements on everything label Jan 2, 2025
@Abyss-lord
Copy link
Contributor

I would like to work on it.

@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Jan 6, 2025
@jerryshao
Copy link
Contributor

Hi @Abyss-lord can you please work on this, we hope that this can be merged in 0.8 release.

@Abyss-lord
Copy link
Contributor

@jerryshao plz assign to me

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 11, 2025
@Abyss-lord
[apache#6069] docs(docs): Fix access-control.md
11c8b17 
 access-control.md
@Abyss-lord Abyss-lord mentioned this issue Jan 11, 2025
Merged
jerryshao pushed a commit that referenced this issue Jan 13, 2025
@Abyss-lord
[#6069] fix(docs): Fix access-control.md (#6189)
9815cc3 
### What changes were proposed in this pull request?

Fix the wrong document information about revoke roles from role

### Why are the changes needed?

Fix: #6069 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
github-actions bot pushed a commit that referenced this issue Jan 13, 2025
@Abyss-lord @web-flow
[#6069] fix(docs): Fix access-control.md (#6189)
9c344e4 
### What changes were proposed in this pull request?

Fix the wrong document information about revoke roles from role

### Why are the changes needed?

Fix: #6069 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
@github-actions github-actions bot mentioned this issue Jan 13, 2025
Merged
jerryshao pushed a commit that referenced this issue Jan 13, 2025
@github-actions @Abyss-lord
[#6069] fix(docs): Fix access-control.md (#6199)
51c70f4 
### What changes were proposed in this pull request?

Fix the wrong document information about revoke roles from role

### Why are the changes needed?

Fix: #6069 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.

Co-authored-by: Lord of Abyss <[email protected]>
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 14, 2025
@Abyss-lord
[apache#6069] fix(docs): Fix access-control.md (apache#6189)
e7f2450 
### What changes were proposed in this pull request?

Fix the wrong document information about revoke roles from role

### Why are the changes needed?

Fix: apache#6069 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
0.8.0 Release v0.8.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6069] fix(docs): Fix access-control.md Abyss-lord/gravitino
3 participants
@jerryshao @LiuJun302 @Abyss-lord