Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Refactor Iceberg REST server credential code #6024

Closed
FANNG1 opened this issue Dec 27, 2024 · 0 comments · Fixed by #6021
Closed

[Improvement] Refactor Iceberg REST server credential code #6024

FANNG1 opened this issue Dec 27, 2024 · 0 comments · Fixed by #6021
Assignees
Labels
0.8.0 Release v0.8.0 improvement Improvements on everything

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Dec 27, 2024

What would you like to be improved?

After supporting credential vending in Gravitino server, we introduced some common component like CatalogCredentialManager CredentialCache, we 'd do a refactor for Iceberg REST server credential code to reuse the component

How should we improve?

No response

@FANNG1 FANNG1 added the improvement Improvements on everything label Dec 27, 2024
jerryshao pushed a commit that referenced this issue Dec 30, 2024
…ential component in Gravitino server (#6021)

### What changes were proposed in this pull request?

1. reuse `CatalogCredentialManager` to manage the credentials in Iceberg
catalog.
2. use `CatalogWrapperForREST` to manage some REST specific operations
like credential vending.
3. depracate `catalog-provider-type` , use `catalog-providers` instead.

### Why are the changes needed?

Fix: #6024 

### Does this PR introduce _any_ user-facing change?

yes, depracate `catalog-provider-type` , use `catalog-providers`, do
some compatibility work.

### How was this patch tested?
run with s3 token
@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.8.0 Release v0.8.0 improvement Improvements on everything
Projects
None yet
2 participants