Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove RocksDBKvBackend and related code & dependencies from code base. #5633

Closed
yuqi1129 opened this issue Nov 20, 2024 · 5 comments · Fixed by #5645
Closed

[Improvement] Remove RocksDBKvBackend and related code & dependencies from code base. #5633

yuqi1129 opened this issue Nov 20, 2024 · 5 comments · Fixed by #5645
Assignees
@pithecuse527
Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Nov 20, 2024 •
edited
Loading

What would you like to be improved?

RocksDBKvBackend is NOT maintained by the community, so we'd better to remove the related code. the whole things could included

  • Remove package org.apache.gravitino.storage.kv and related dependency class
  • Remove related jars from the project
  • Remove docs about RocksDBKvBackend if possible.

How should we improve?

No response
@yuqi1129 yuqi1129 added improvement Improvements on everything good first issue Good for newcomers help wanted Extra attention is needed labels Nov 20, 2024
@yuqi1129 yuqi1129 changed the title [Improvement] Remove RocksDBKvBackend and related code and dependencies from code base. [Improvement] Remove RocksDBKvBackend and related code & dependencies from code base. Nov 20, 2024
@pithecuse527
Copy link
Contributor

May I take this?

@yuqi1129
Copy link
Contributor Author

May I take this?

Sure,please go on and I will assign it to you.

@JunpingDu JunpingDu assigned JunpingDu and pithecuse527 and unassigned JunpingDu Nov 21, 2024
@JunpingDu
Copy link
Contributor

@pithecuse527 just assigned, thanks for help here.

@pithecuse527
Copy link
Contributor

pithecuse527 commented Nov 21, 2024 •
edited
Loading

I have a few questions as I go through the code. It would be better to clarify what I need to do.

  1. Is this issue related to [EPIC] Support another KV storage except RocksDB #2290?
    (Is this why we need to remove the RocksDB-related code?)

  2. Should I remove the entire org.apache.gravitino.storage.kv package, or just the parts related to RocksDB?

  3. If you're considering using a different key-value storage backend in the future, wouldn’t it be better to keep the other classes in the package to support that?

Thank you.

@yuqi1129
Copy link
Contributor Author

@yuqi1129

Is this issue related to [EPIC] Support another KV storage except RocksDB #2290?
(Is this why we need to remove the RocksDB-related code?)

Kv Storage backend will not be supported, so we are going to remove all kv storage backend including RocksDBKvBackend.

Should I remove the entire org.apache.gravitino.storage.kv package, or just the parts related to RocksDB?

Remove all Kv Storage backend and related kv storage backend interface and correspondingly implementation.

If you're considering using a different key-value storage backend in the future, wouldn’t it be better to keep the other classes in the package to support that?

We will not support KV storage backend storage in the near future, so I believe we can remove it temporarily. If we plan to support it again in the future, I think we can add back or design a better one.

pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 22, 2024
@pithecuse527
[apache#5633] remove the key-value storage backend logic
e3235d4
@pithecuse527 pithecuse527 mentioned this issue Nov 22, 2024
Merged
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 22, 2024
@pithecuse527
[apache#5633] remove meta protobuf and its serde implementations
726c0c3
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 26, 2024
@pithecuse527
[apache#5633] recover the exclusion of the rocksdb module
0421bd2
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 26, 2024
@pithecuse527
[apache#5633] remove unnecessary classes from the storage module
0751646
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 27, 2024
@pithecuse527
[apache#5633] remove the key-value storage backend logic
d533bb3
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 28, 2024
@pithecuse527
[apache#5633] remove the entity serde config and doc
4597885
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Nov 28, 2024
@pithecuse527
[apache#5633] mark the rfc-2 document as deprecated
e1056f7
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 4, 2024
@pithecuse527
[apache#5633] remove the key-value storage backend logic
46cae48
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 4, 2024
@pithecuse527
[apache#5633] remove the key-value storage backend logic
a42fae7
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 4, 2024
@pithecuse527
[apache#5633] remove the key-value storage backend logic
deae27e
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 8, 2024
@pithecuse527
[apache#5633] remove the key-value storage backend logic
a92dda1
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 8, 2024
@pithecuse527
[apache#5633] change the rfc2 document from deprecated to removed
8658c82
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 9, 2024
@pithecuse527
[apache#5633] revoke the rfc3 document and mark it as removed
6079ad0
pithecuse527 added a commit to pithecuse527/gravitino that referenced this issue Dec 10, 2024
@pithecuse527
[apache#5633] revert the rfc2 document name
92d2d35
@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Dec 10, 2024
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this issue Dec 13, 2024
@pithecuse527 @Abyss-lord
[apache#5633] remove the key-value storage backend logic (apache#5645)
61769a6 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Remove Key-Value storage backend storage implementations

### Why are the changes needed?

Fix: apache#5633

### Does this PR introduce _any_ user-facing change?
yes

### How was this patch tested?
Remove tests for the Key-Value storage implementation code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pithecuse527 pithecuse527

Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers help wanted Extra attention is needed improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5633] remove the key-value storage backend logic pithecuse527/gravitino
4 participants
@jerryshao @JunpingDu @yuqi1129 @pithecuse527