Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] add view event for Iceberg REST server #5438

Closed
Tracked by #5204
FANNG1 opened this issue Nov 4, 2024 · 6 comments · Fixed by #5584
Closed
Tracked by #5204

[Subtask] add view event for Iceberg REST server #5438

FANNG1 opened this issue Nov 4, 2024 · 6 comments · Fixed by #5584
Assignees
@orenccl
Labels
0.8.0 Release v0.8.0 help wanted Extra attention is needed subtask Subtasks of umbrella issue

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Nov 4, 2024

Describe the subtask

Please refer to #4958 and #5205 about how to support table event. You may need to implement an IcebergViewOperationDispatcher IcebergViewEventDispatcher like IcebergTableOperationDispatcher IcebergTableEventDispatcher

Parent issue

#5204
@FANNG1 FANNG1 added subtask Subtasks of umbrella issue 0.7.0 Release v0.7.0 help wanted Extra attention is needed and removed 0.7.0 Release v0.7.0 labels Nov 4, 2024
@FANNG1 FANNG1 mentioned this issue Nov 4, 2024
Closed
4 tasks
@orenccl
Copy link
Collaborator

orenccl commented Nov 13, 2024 •
edited
Loading

I'm working on it.

@orenccl
Copy link
Collaborator

orenccl commented Nov 14, 2024

Hi @FANNG1,

I have some questions about IcebergTableOperation. What are the access and credential parts, and why does updateTableRequest need to be serialized? Could you give me a quick hint so I can do the rest of the research myself?

@orenccl orenccl mentioned this issue Nov 14, 2024
Merged
@FANNG1
Copy link
Contributor Author

FANNG1 commented Nov 15, 2024 •
edited
Loading

I have some questions about IcebergTableOperation. What are the access and credential parts.

Sorry, I couldn't get your point, you mean accessDelegation?

and why does updateTableRequest need to be serialized?

It's like clone, to prevent the event listener from affecting the normal process if changing the object. We relax the restrictions in pre-event, and add the restrictions in post-event.

@orenccl
Copy link
Collaborator

orenccl commented Nov 15, 2024

Thanks for replay, yes i mean accessDelegation

@FANNG1
Copy link
Contributor Author

FANNG1 commented Nov 15, 2024

accessDelegation is a flag to enable credential vending for Iceberg REST server, please refer to https://tabular.medium.com/securing-the-data-lake-part-1-fe8e4694b09d https://docs.google.com/document/d/1fovK0ylSmI45ynrCPcnRZqzyPDn7DRNb_ExdbjVPq0k/edit?tab=t.0#heading=h.1cts6muko2j1

@orenccl
Copy link
Collaborator

orenccl commented Nov 15, 2024

Thank you!

FANNG1 pushed a commit that referenced this issue Nov 16, 2024
@orenccl
[#5438] feat(iceberg): add view event for Iceberg REST server (#5584)
13c92f9 
### What changes were proposed in this pull request?

Add view event for Iceberg REST server

### Why are the changes needed?

Close: #5438

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

unit test
@FANNG1 FANNG1 added the 0.8.0 Release v0.8.0 label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orenccl orenccl

Labels
0.8.0 Release v0.8.0 help wanted Extra attention is needed subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5438] feat(iceberg): add view event for Iceberg REST server orenccl/gravitino
2 participants
@FANNG1 @orenccl