Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] CatalogMysqlDriverIT miss driver url #5289

Open
mchades opened this issue Oct 28, 2024 · 5 comments · May be fixed by #5431
Open

[Improvement] CatalogMysqlDriverIT miss driver url #5289

mchades opened this issue Oct 28, 2024 · 5 comments · May be fixed by #5431
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@mchades
Copy link
Contributor

mchades commented Oct 28, 2024

What would you like to be improved?

CatalogMysqlDriverIT does not work in factor since the driver URL does not be updated:

@Tag("gravitino-docker-test")
public class CatalogMysqlDriverIT extends CatalogMysqlIT {
public CatalogMysqlDriverIT() {
super();
}
}

How should we improve?

update the driver version from 8.0.26 to 8.0.11

@mchades mchades added improvement Improvements on everything good first issue Good for newcomers labels Oct 28, 2024
@lsyulong
Copy link
Contributor

I want to try it, but I don't know how to modify it. Can you help me

@mchades
Copy link
Contributor Author

mchades commented Oct 28, 2024

remove static final modifier of DOWNLOAD_MYSQL_JDBC_DRIVER_URL in BaseIT, then change it to https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.11/mysql-connector-java-8.0.11.jar in CatalogMysqlDriverIT

@lsyulong
Copy link
Contributor

image
image
Does this solve the current problem, and do we still need to write unit tests

@mchades
Copy link
Contributor Author

mchades commented Nov 1, 2024

It's enough. tests will be automatically inherited.

@lsyulong
Copy link
Contributor

lsyulong commented Nov 1, 2024

It's enough. tests will be automatically inherited.够了。测试将自动继承。

OK,thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
2 participants