Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Support Expression system #5201

Closed
Tracked by #5198
unknowntpo opened this issue Oct 21, 2024 · 3 comments · Fixed by #5646
Closed
Tracked by #5198

[Subtask] Support Expression system #5201

unknowntpo opened this issue Oct 21, 2024 · 3 comments · Fixed by #5646
Assignees
@SophieTech88
Labels
0.8.0 Release v0.8.0 subtask Subtasks of umbrella issue

Comments

@unknowntpo
Copy link
Contributor

Describe the subtask

Support Expression system
docs
related java issue: #600

Parent issue

#5198
@unknowntpo unknowntpo added the subtask Subtasks of umbrella issue label Oct 21, 2024
@unknowntpo unknowntpo mentioned this issue Oct 21, 2024
Open
10 tasks
@SophieTech88
Copy link
Contributor

Can I work on this issue?

@SophieTech88
Copy link
Contributor

I noticed that the file expressions/Literal.java includes the comment: @deprecated This interface will be removed. Additionally, there’s a folder expressions/literals/ containing two files: Literal.java and Literals.java.

For the Python client, which of these files should I implement? Should I focus on the new implementation in expressions/literals/, or is there a need to maintain compatibility with the deprecated interface?

@SophieTech88
Copy link
Contributor

Another question: under the expressions folder, there are several subfolders like distributions, sorts, transforms, and literals, as well as files such as Expression.java, FunctionExpression.java, Literal.java, NamedReference.java, and UnparsedExpression.java.

Could you confirm if all of these need to be converted into Python client interfaces, or are there specific ones I should focus on?

@SophieTech88 SophieTech88 mentioned this issue Nov 22, 2024
Merged
@mchades mchades added the 0.8.0 Release v0.8.0 label Dec 5, 2024
mchades pushed a commit that referenced this issue Dec 5, 2024
@SophieTech88 @xunliu
[#5201] feat(client-python): Implement expressions in python client (#…
10fc5cd 
…5646)

### What changes were proposed in this pull request?
Implement expression from java, including:
- Expression.java
- FunctionExpression.java
- NamedReference.java
- UnparsedExpression.java
- literals/

convert to python client, and add unit test for each class.

### Why are the changes needed?

We need to support the expressions in python client

Fix: #5201

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Need to pass all unit tests.

---------

Co-authored-by: Xun <[email protected]>
jerryshao pushed a commit that referenced this issue Dec 6, 2024
@SophieTech88 @xunliu @jerryshao
[#5201] feat(client-python): Implement expressions in python client (#…
a606c1b 
…5646)

### What changes were proposed in this pull request?
Implement expression from java, including:
- Expression.java
- FunctionExpression.java
- NamedReference.java
- UnparsedExpression.java
- literals/

convert to python client, and add unit test for each class.

### Why are the changes needed?

We need to support the expressions in python client

Fix: #5201

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Need to pass all unit tests.

---------

Co-authored-by: Xun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SophieTech88 SophieTech88

Labels
0.8.0 Release v0.8.0 subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5201] feat(client-python): Implement expressions in python client SophieTech88/gravitino
3 participants
@unknowntpo @mchades @SophieTech88