Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] refine drop metalake semantics and behavior #5154

Closed
Tracked by #5031
mchades opened this issue Oct 16, 2024 · 0 comments · Fixed by #5155
Closed
Tracked by #5031

[Subtask] refine drop metalake semantics and behavior #5154

mchades opened this issue Oct 16, 2024 · 0 comments · Fixed by #5155
Assignees
@mchades
Labels
0.7.0 Release v0.7.0 subtask Subtasks of umbrella issue

Comments

@mchades
Copy link
Contributor

mchades commented Oct 16, 2024 •
edited
Loading

Describe the subtask

  • Add "in-use" as the property and set "true" as the default value for metalake.
  • Add "force" parameter to drop metalake API
  • Add "enableMetalake()" and "disableMetalake()" API for metalake
  • Check metalake in use before operate entities

Parent issue

#5031
@mchades mchades added the subtask Subtasks of umbrella issue label Oct 16, 2024
@mchades mchades self-assigned this Oct 16, 2024
This was referenced Oct 16, 2024
Closed
Merged
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Oct 21, 2024
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@mchades @mplmoknijb
[apache#5154] refactor(drop-metalake): re-define drop metalake (apach…
7e4b387 
…e#5155)

### What changes were proposed in this pull request?

- Add an in-use property to the metalake with the default value of true.
- Only empty metalake with in-use=false can be dropped when
`force=false`
 - User can use `dorce` option to drop metalake
- More drop metalake limitations please see the JavaDoc of
`dropMetalake` in API module

### Why are the changes needed?

Fix: apache#5154 

### Does this PR introduce _any_ user-facing change?

yes, users now can not drop an in used metalake

### How was this patch tested?

tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
0.7.0 Release v0.7.0 subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5154] refactor(drop-metalake): re-define drop metalake mchades/gravitino
2 participants
@jerryshao @mchades