Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] refine drop catalog semantics and behavior #5066

Closed
Tracked by #5031
mchades opened this issue Oct 8, 2024 · 0 comments · Fixed by #5067
Closed
Tracked by #5031

[Subtask] refine drop catalog semantics and behavior #5066

mchades opened this issue Oct 8, 2024 · 0 comments · Fixed by #5067
Assignees
@mchades
Labels
0.7.0 Release v0.7.0 subtask Subtasks of umbrella issue

Comments

@mchades
Copy link
Contributor

mchades commented Oct 8, 2024 •
edited
Loading

Describe the subtask

  • Add "in-use" as the property and set "true" as the default value for the catalog.
  • Add "force" parameter to drop catalog API
  • Add "enableCatalog()" and "disableCatalog()" API for catalog

Parent issue

#5031
@mchades mchades added the subtask Subtasks of umbrella issue label Oct 8, 2024
@mchades mchades self-assigned this Oct 8, 2024
@mchades mchades mentioned this issue Oct 8, 2024
Merged
@mchades mchades mentioned this issue Oct 16, 2024
Closed
5 tasks
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Oct 18, 2024
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@mchades @mplmoknijb
[apache#5066] refactor(drop-catalog): re-define drop catalog (apache#…
122815d 
…5067)

### What changes were proposed in this pull request?

- Add an `in-use` property to the catalog with the default value of
true.
 - Only empty catalog with `in-use=false` can be dropped.
 - User can use `dorce` option to drop catalog 
- More drop catalog limitations please see the JavaDoc of `dropCatalog`
in API module

### Why are the changes needed?

Fix: apache#5066 

### Does this PR introduce _any_ user-facing change?

yes, users now can not drop an in used catalog

### How was this patch tested?

tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
0.7.0 Release v0.7.0 subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5066] refactor(drop-catalog): re-define drop catalog mchades/gravitino
2 participants
@jerryshao @mchades