Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] UI: scroll bar on the catalog detail page is no longer needed #4641

Closed
danhuawang opened this issue Aug 23, 2024 · 3 comments · Fixed by #5271
Closed

[Bug report] UI: scroll bar on the catalog detail page is no longer needed #4641

danhuawang opened this issue Aug 23, 2024 · 3 comments · Fixed by #5271
Assignees
@LauraXia123
Labels
0.7.0 Release v0.7.0 bug Something isn't working good first issue Good for newcomers
Milestone
Gravitino 0.7.0

Comments

@danhuawang
Copy link
Contributor

Version

main branch

Describe what's wrong

image

Error message and/or stacktrace

N/A

How to reproduce

  1. create a catalog
  2. check detail page

Additional context

No response
@danhuawang danhuawang added the bug Something isn't working label Aug 23, 2024
@danhuawang
Copy link
Contributor Author

@LauraXia123 how to handle the scroll bar on the catalog detail page since long text is hidden ?

@LauraXia123
Copy link
Collaborator

LauraXia123 commented Aug 23, 2024 •
edited
Loading

The substring of value is 22 for now, we can set the length of substring smaller. But the scroll bar still work when open with sm screen.
We can use css way to replace the substring way.
IMO, we can label the issue 'first good issue'

@jerryshao jerryshao added this to the Gravitino 0.7.0 milestone Oct 25, 2024
@LauraXia123 LauraXia123 added the good first issue Good for newcomers label Oct 25, 2024
@LauraXia123
Copy link
Collaborator

image

LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue Oct 25, 2024
@LauraXia123
[apache#4641] fix(web): improvement scroll bar on the catalog detail …
a21965a 
…page ellipsis display
LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue Oct 25, 2024
@LauraXia123
[apache#4641] fix(web): improvement scroll bar on the catalog detail …
28989e9 
…page ellipsis display
@LauraXia123 LauraXia123 mentioned this issue Oct 25, 2024
Merged
github-actions bot pushed a commit that referenced this issue Oct 28, 2024
@LauraXia123 @web-flow
[#4641] fix(web): improvement scroll bar on the catalog detail page e…
782a376 
…llipsis display (#5271)

### What changes were proposed in this pull request?

improvement scroll bar on the catalog detail page ellipsis display

![image](https://github.com/user-attachments/assets/de7e44ea-0c37-4b34-ab52-c171259e3bf2)

Fix: #4641

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manually
@github-actions github-actions bot mentioned this issue Oct 28, 2024
Merged
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Oct 28, 2024
jerryshao pushed a commit that referenced this issue Oct 28, 2024
@github-actions @LauraXia123
[#4641] fix(web): improvement scroll bar on the catalog detail page e…
41d2459 
…llipsis display (#5287)

### What changes were proposed in this pull request?

improvement scroll bar on the catalog detail page ellipsis display

![image](https://github.com/user-attachments/assets/de7e44ea-0c37-4b34-ab52-c171259e3bf2)

Fix: #4641

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manually

Co-authored-by: Qian Xia <[email protected]>
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@LauraXia123 @mplmoknijb
[apache#4641] fix(web): improvement scroll bar on the catalog detail …
9832b27 
…page ellipsis display (apache#5271)

### What changes were proposed in this pull request?

improvement scroll bar on the catalog detail page ellipsis display

![image](https://github.com/user-attachments/assets/de7e44ea-0c37-4b34-ab52-c171259e3bf2)

Fix: apache#4641

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraXia123 LauraXia123

Labels
0.7.0 Release v0.7.0 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Gravitino 0.7.0
3 participants
@jerryshao @LauraXia123 @danhuawang