[Improvement] switch statements missing default

[justinmclean]

What would you like to be improved?

Switch statements missing default:

• fillFilesetPOBuilderParentEntityId in FilesetMetaService.java
• fillSchemaPOBuilderParentEntityId in SchemaMetaService.java
• fillTablePOBuilderParentEntityId in TableMetaService.java
• fillTopicPOBuilderParentEntityId in TopicMetaService.java

How should we improve?

add default

[khmgobe]

Let me do it!

[justinmclean]

Note that the check topic call does check that the level length is 3

[khmgobe]

Note that the check topic call does check that the level length is 3

@justinmclean
What should I assign as the default?

[justinmclean]

I would log an error, it would not be possible for this to currently happen, but it might be possible at some point.

[khmgobe]

check topic call

I will add a default statement for the rest except check topic call.

[khmgobe]

I would log an error, it would not be possible for this to currently happen, but it might be possible at some point.

ok Thanks!

[justinmclean]

@khmgobe Do you still want to work on this?

[manoharbvk]

Hi I am new to open source contributions, and since this issue is still open, I added default statements to the necessary places. It would be great if you can have a look at this - #4668
Thanks

[khmgobe]

@justinmclean

It's okay for someone else to contribute.

[manoharbvk]

@justinmclean There are some issues on the Linux system on my side, and this is not running... If anyone else is interested in contributing to this, please let them do so. Thanks.