Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add PostHook menchinism for managers #4236

Closed
jerqi opened this issue Jul 23, 2024 · 0 comments · Fixed by #4239 or #4429
Closed

[Improvement] Add PostHook menchinism for managers #4236

jerqi opened this issue Jul 23, 2024 · 0 comments · Fixed by #4239 or #4429
Assignees
@jerqi
Labels
0.6.0 Release v0.6.0 improvement Improvements on everything

Comments

@jerqi
Copy link
Contributor

jerqi commented Jul 23, 2024

What would you like to be improved?

Add preHook,postHook menchinism for managers

How should we improve?

Add preHook,postHook menchinism for managers
@jerqi jerqi added the improvement Improvements on everything label Jul 23, 2024
@jerqi jerqi changed the title [Improvement] Add preHook,postHook menchinism for managers [Improvement] Add PostHook menchinism for managers Jul 23, 2024
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 23, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
24bee12 
…dispatcher
@jerqi jerqi mentioned this issue Jul 23, 2024
Merged
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 23, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
cd3526b 
…dispatcher
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 23, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
e70cd64 
…dispatcher
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 23, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
e063851 
…dispatcher
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 23, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
d36f6d1 
…dispatcher
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 23, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
feef232 
…dispatcher
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 29, 2024
@jerqi
[apache#4236] feat(core): Supports the post-hook for the managers or …
14a90d0 
…dispatcher
xunliu pushed a commit to qqqttt123/gravitino that referenced this issue Jul 31, 2024
@jerqi @xunliu
[apache#4236] feat(core): Supports the post-hook for the managers or …
482a723 
…dispatcher
xunliu pushed a commit that referenced this issue Jul 31, 2024
@jerqi
[#4236] feat(core): Supports the post-hook for the managers or dispat…
851c463 
…cher (#4239)

### What changes were proposed in this pull request?
Supports the post-hook for the managers or dispatcher.
For example, after we create a securable object, we should set an owner
for it. We can add a specific post hook to support it.
This pull request uses Java dynamic proxy mechanism to support this
feature. We only support post-hook now, we can support pre-hook in the
future.

### Why are the changes needed?

Fix: #4236 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Add a new ut.
This was referenced Aug 8, 2024
Merged
Merged
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label Aug 13, 2024
jerryshao pushed a commit that referenced this issue Aug 13, 2024
@jerqi
[#4236] feat(core): Rework of post hook for dispatcher (#4449)
0804634 
### What changes were proposed in this pull request?

Rework of post hook for dispatcher .

1. Implement a new class dispatcher instead dynamic proxy.
2. Optimize the lock logic
3. Add the securable object metalake back. We just remove the privileges
of the metalake. We should remove the securable object metalake.

### Why are the changes needed?

Fix: #4236 

### Does this PR introduce _any_ user-facing change?
NO.

### How was this patch tested?

Add new ITs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

Labels
0.6.0 Release v0.6.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
2 participants
@jerryshao @jerqi