Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] test_gvfs_with_local.py would fail if run after test_simple_auth_provider.py #4136

Closed
noidname01 opened this issue Jul 11, 2024 · 0 comments
Assignees
Labels
0.6.0 Release v0.6.0 bug Something isn't working

Comments

@noidname01
Copy link
Collaborator

noidname01 commented Jul 11, 2024

Version

main branch

Describe what's wrong

  • test_simple_auth_provider.py will set the enviroment variable globally, so all testcase run after it will be influenced
  • All testcases between files should not interfere wih each other

Error message and/or stacktrace

image

How to reproduce

The unittest module will run all test with lexical order, so if we change the file structure like this, the test would fail.
image

Additional context

No response

@noidname01 noidname01 added the bug Something isn't working label Jul 11, 2024
jerryshao pushed a commit that referenced this issue Jul 19, 2024
…ython client (#4011)

### What changes were proposed in this pull request?

* Add `OAuth2TokenProvider` and `DefaultOAuth2TokenProvider` in
`client-python`
* There are some components and tests missing because it would be a big
code change if they were also done in this PR, they will be added in the
following PRs
	- [ ] Error Handling: #4173 
	- [ ] Integration Test: #4208 
* Modify test file structure, and found issue #4136, solve it by reset
environment variable.

### Why are the changes needed?

Fix: #3755, #4136

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Add UT and tested by `./gradlew clients:client-python:unittest`

---------

Co-authored-by: TimWang <[email protected]>
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6.0 Release v0.6.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants