Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the package name to use org.apache.gravitino #4036

Closed
Tracked by #4034
jerryshao opened this issue Jul 3, 2024 · 9 comments · Fixed by #4057 or #4162
Closed
Tracked by #4034

Update the package name to use org.apache.gravitino #4036

jerryshao opened this issue Jul 3, 2024 · 9 comments · Fixed by #4057 or #4162
Assignees
@yuqi1129 @rich7420
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jerryshao
Copy link
Contributor

No description provided.

@jerryshao jerryshao mentioned this issue Jul 3, 2024
Open
29 tasks
@jerryshao jerryshao added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 3, 2024
@rich7420
Copy link
Contributor

rich7420 commented Jul 3, 2024

I’m interested in working on this issue. Can you please provide more details about this issue?

@jerryshao
Copy link
Contributor Author

The current package name is "com.datastrato.gravitino.xxx", we need to change to "org.apache.gravitino.xxx" in everywhere, like java/python code, scripts, documents.

@rich7420
Copy link
Contributor

rich7420 commented Jul 3, 2024

@jerryshao Ok, Can I assign this issue?

@jerryshao
Copy link
Contributor Author

You can go ahead, after the PR is merged, I will assign the issue to you.

@rich7420
Copy link
Contributor

rich7420 commented Jul 3, 2024 •
edited
Loading

No problem. thank you for your feedback.

@rich7420
Copy link
Contributor

rich7420 commented Jul 3, 2024

@jerryshao hello , after I changed all the "com.datastrato.gravitino.xxx" to "org.apache.gravitino.xxx" , it came out when I ran ./gradlew build . What can I improve this?
Snipaste_2024-07-03_22-23-55

@jerryshao
Copy link
Contributor Author

I think you should grep all the file contents as well as the file name to see if it is modified. You must miss something, for example like service loader file.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 3, 2024

@rich7420
If the issue still persists, please push your branch to Github and we will help to check it.

@rich7420
Copy link
Contributor

rich7420 commented Jul 3, 2024

@yuqi1129 Ok! Thank you for your feedback.

@rich7420 rich7420 mentioned this issue Jul 3, 2024
Merged
jerryshao added a commit to jerryshao/gravitino that referenced this issue Jul 15, 2024
@jerryshao
Revert "[apache#4036] Update the package name to use org.apache.gravi…
60ec588 
…tino (apache#4057)"

This reverts commit f3f0c99.
yuqi1129 pushed a commit that referenced this issue Jul 15, 2024
@jerryshao
Revert "[#4036] Update the package name to use org.apache.gravitino(#…
446d30f 
…4057) (#4161)

Revert #4057 as the package name is not correct.
@yuqi1129 yuqi1129 mentioned this issue Jul 15, 2024
Merged
jerryshao added a commit that referenced this issue Jul 16, 2024
@yuqi1129 @jerryshao
[#4036] improvement(all): Change package to 'org.apache.' (#4162)
6990036 
### What changes were proposed in this pull request?

- Update the package name from com.datastrato.gravitino to
org.apache.gravitino

### Why are the changes needed?

- Repo moved.
Fix: #4036

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

`./gradlew build`

---------

Co-authored-by: Jerry Shao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

@rich7420 rich7420

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@jerryshao @yuqi1129 @rich7420