Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Python client loss depends library in the requirements-dev #3944

Closed
xunliu opened this issue Jun 22, 2024 · 0 comments · Fixed by #3945
Closed

[Bug report] Python client loss depends library in the requirements-dev #3944

xunliu opened this issue Jun 22, 2024 · 0 comments · Fixed by #3945
Assignees
Labels
bug Something isn't working

Comments

@xunliu
Copy link
Member

xunliu commented Jun 22, 2024

Version

main branch

Describe what's wrong

When you execut
./client-python/.venv/bin/python /Applications/PyCharm.app/Contents/plugins/python/helpers/pycharm/_jb_unittest_runner.py --target test_fileset_catalog.TestFilesetCatalog
return failed.

Error message and/or stacktrace

Error
Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 34, in testFailure
    raise self._exception
ImportError: Failed to import test module: test_fileset_catalog
Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/Users/xun/github/xunliu/gravitino/clients/client-python/tests/integration/test_fileset_catalog.py", line 10, in <module>
    from gravitino import (
  File "/Users/xun/github/xunliu/gravitino/clients/client-python/gravitino/__init__.py", line 16, in <module>
    from gravitino.filesystem import gvfs
  File "/Users/xun/github/xunliu/gravitino/clients/client-python/gravitino/filesystem/gvfs.py", line 12, in <module>
    from cachetools import TTLCache
ModuleNotFoundError: No module named 'cachetools'

How to reproduce

Add cachetools and readerwriterlock Python depends library in to requirements-dev.txt
cachetools==5.3.3
readerwriterlock==1.0.9

Additional context

No response

@xunliu xunliu added the bug Something isn't working label Jun 22, 2024
@xunliu xunliu self-assigned this Jun 22, 2024
xunliu added a commit to xunliu/gravitino that referenced this issue Jun 22, 2024
mchades pushed a commit to mchades/gravitino that referenced this issue Jun 24, 2024
…e requirements-dev (apache#3945)

### What changes were proposed in this pull request?

Add lose Python depends on library into `requirements-dev.txt`
```
cachetools==5.3.3
readerwriterlock==1.0.9
```

### Why are the changes needed?

Fix: apache#3944

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI Passed.
shaofengshi pushed a commit to shaofengshi/gravitino that referenced this issue Jun 24, 2024
…e requirements-dev (apache#3945)

### What changes were proposed in this pull request?

Add lose Python depends on library into `requirements-dev.txt`
```
cachetools==5.3.3
readerwriterlock==1.0.9
```

### Why are the changes needed?

Fix: apache#3944

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI Passed.
coolderli pushed a commit that referenced this issue Dec 17, 2024
…irements-dev (#3945)

### What changes were proposed in this pull request?

Add lose Python depends on library into `requirements-dev.txt`
```
cachetools==5.3.3
readerwriterlock==1.0.9
```

### Why are the changes needed?

Fix: #3944

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI Passed.

(cherry picked from commit 141c9c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants