Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Supports to allocate an entity id for every external entity #3607

Closed
jerqi opened this issue May 28, 2024 · 0 comments · Fixed by #3623
Closed

[Improvement] Supports to allocate an entity id for every external entity #3607

jerqi opened this issue May 28, 2024 · 0 comments · Fixed by #3623
Assignees
@jerqi
Labels
0.6.0 Release v0.6.0 improvement Improvements on everything

Comments

@jerqi
Copy link
Contributor

jerqi commented May 28, 2024

What would you like to be improved?

For privilege system and tag system, we should have entity id for every external entity to record the relationship between privileges/tags and entities. We can't use the name of entity. Otherwise, we can't satisfy the situation of renaming.

How should we improve?

If there not exists an entity in our storage, we will create it in our storage, when we load an external entity.
@jerqi jerqi added the improvement Improvements on everything label May 28, 2024
@qqqttt123 qqqttt123 mentioned this issue Jun 6, 2024
Merged
jerryshao added a commit that referenced this issue Jun 18, 2024
@qqqttt123 @jerqi @jerryshao
[#3607] feat(core): Support to import the entities when loading entit…
c0f8be0 
…ies (#3623)

### What changes were proposed in this pull request?
Support to import the entities when loading entities

### Why are the changes needed?

Fix: #3607 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Add ut.

---------

Co-authored-by: Heng Qin <[email protected]>
Co-authored-by: Rory <[email protected]>
Co-authored-by: Jerry Shao <[email protected]>
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label Jun 18, 2024
shaofengshi pushed a commit to shaofengshi/gravitino that referenced this issue Jun 24, 2024
@qqqttt123 @jerqi
@jerryshao @shaofengshi
[apache#3607] feat(core): Support to import the entities when loading…
d3b15e9 
… entities (apache#3623)

### What changes were proposed in this pull request?
Support to import the entities when loading entities

### Why are the changes needed?

Fix: apache#3607 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Add ut.

---------

Co-authored-by: Heng Qin <[email protected]>
Co-authored-by: Rory <[email protected]>
Co-authored-by: Jerry Shao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

Labels
0.6.0 Release v0.6.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3607] feat(core): Support to import the entities when loading entities qqqttt123/gravitino
2 participants
@jerryshao @jerqi