Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Test arguments should be in the right order #3252

Closed
justinmclean opened this issue May 2, 2024 · 2 comments · Fixed by #3255
Closed

[Improvement] Test arguments should be in the right order #3252

justinmclean opened this issue May 2, 2024 · 2 comments · Fixed by #3255
Assignees
@kristopherkane
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

A minor issue, but can cause confusion, test arguments should be in the right order.

Instances are as follows:
x3 in CatalogsPageTest.java:

Assertions.assertEquals(driver.getTitle(), WEB_TITLE);

In TestHivePropertiesConverter.java:

Assertions.assertEquals(hiveProperties.get(HivePropertiesConstants.GRAVITINO_HIVE_FORMAT), "PARQUET");

How should we improve?

Swap order of arguments.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels May 2, 2024
kristopherkane added a commit to kristopherkane/gravitino that referenced this issue May 3, 2024
@kristopherkane
apache#3252 fix test assertion parameter order.
4b91e22
@kristopherkane kristopherkane mentioned this issue May 3, 2024
Merged
kristopherkane added a commit to kristopherkane/gravitino that referenced this issue May 4, 2024
@kristopherkane
apache#3252 linting.
d8468e5
justinmclean pushed a commit that referenced this issue May 5, 2024
@kristopherkane
[#3252] Improvement(IT): Test arguments should be in the right order (#…
841475c 
…3255)

### What changes were proposed in this pull request?

Equality assertions did not have correct expected and actual order. 

### Why are the changes needed?

Provides code clarity. 

Fix: #3252 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Test only changes and ran associated tests.
@jerryshao
Copy link
Contributor

@kristopherkane can you please leave a comment here? So we can assign this issue to you.

@jerryshao jerryshao added the 0.6.0 label May 6, 2024
@justinmclean justinmclean changed the title [Improvement] Test arguments shoudl be in the right order [Improvement] Test arguments should be in the right order May 6, 2024
@kristopherkane
Copy link
Contributor

PR merged for 3252.

diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@kristopherkane @diqiu50
[apache#3252] Improvement(IT): Test arguments should be in the right …
8076402 
…order (apache#3255)

### What changes were proposed in this pull request?

Equality assertions did not have correct expected and actual order. 

### Why are the changes needed?

Provides code clarity. 

Fix: apache#3252 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Test only changes and ran associated tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristopherkane kristopherkane

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3252] Improvement(IT): Test arguments should be in the right order kristopherkane/gravitino
3 participants
@justinmclean @kristopherkane @jerryshao