Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] assertThat should do that #3251

Closed
justinmclean opened this issue May 2, 2024 · 2 comments · Fixed by #3263
Closed

[Improvement] assertThat should do that #3251

justinmclean opened this issue May 2, 2024 · 2 comments · Fixed by #3263
Assignees
@rohit-satya
Labels
0.6.0 Release v0.6.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

AssertThat should be followed by an assertion, however assertThat(computeActual("select * from system.jdbc.tables")); in TestGravitinoConnector.java and assertThat(computeActual("select * from system.jdbc.tables")); in TestGravitinoConnectorWithMetalakeCatalogName.java do not.

How should we improve?

Fix the assertions.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels May 2, 2024
@ishan-gupt
Copy link

@justinmclean can you assign this to me

@rohit-satya rohit-satya mentioned this issue May 4, 2024
Merged
@rohit-satya
Copy link
Contributor

@justinmclean Please review above PR

justinmclean pushed a commit that referenced this issue May 5, 2024
@rohit-satya
[3251] Improvement: fix assertion (#3263)
41a1b11 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Fixed assertion



Fix:  #3251

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Ran test locally multiple times

---------

Signed-off-by: Rohit Satya <[email protected]>
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label May 6, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@rohit-satya @diqiu50
[3251] Improvement: fix assertion (apache#3263)
09ebdca 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Fixed assertion



Fix:  apache#3251

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Ran test locally multiple times

---------

Signed-off-by: Rohit Satya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohit-satya rohit-satya

Labels
0.6.0 Release v0.6.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3251] Improvement: fix assertion rohit-satya/gravitino
4 participants
@justinmclean @jerryshao @ishan-gupt @rohit-satya