Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add @Override to getTableBuilder in PostgreSqlTableOperations.java #3250

Closed
justinmclean opened this issue May 2, 2024 · 1 comment · Fixed by #3267
Closed

[Improvement] Add @Override to getTableBuilder in PostgreSqlTableOperations.java #3250

justinmclean opened this issue May 2, 2024 · 1 comment · Fixed by #3267
Assignees
@MukarramHaq
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

getTableBuilder is missing annotation

How should we improve?

add annotation
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels May 2, 2024
@MukarramHaq
Copy link
Contributor

Hello, I would like to work on this isse.

This was referenced May 3, 2024
Closed
Merged
jerryshao pushed a commit that referenced this issue May 6, 2024
@MukarramHaq
[#3250] improve(catalog-jdbc-pg): Added missing @OverRide annotation (#…
5132717 
…3267)

### What changes were proposed in this pull request?

Added `@Override` annotation on getTableBuilder in
PostgreSqlTableOperations

### Why are the changes needed?

Fix: #3250
github-actions bot pushed a commit that referenced this issue May 6, 2024
@MukarramHaq @web-flow
[#3250] improve(catalog-jdbc-pg): Added missing @OverRide annotation (#…
8373d93 
…3267)

### What changes were proposed in this pull request?

Added `@Override` annotation on getTableBuilder in
PostgreSqlTableOperations

### Why are the changes needed?

Fix: #3250
@jerryshao jerryshao mentioned this issue May 6, 2024
Merged
yuqi1129 pushed a commit that referenced this issue May 6, 2024
@jerryshao @MukarramHaq
[#3250] improve(catalog-jdbc-pg): Added missing @OverRide annotation (#…
c1cdfca 
…3278)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Added `@Override` annotation on getTableBuilder in
PostgreSqlTableOperations

### Why are the changes needed?

Fix: #3250

Co-authored-by: Mukarram Haq <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@MukarramHaq @diqiu50
[apache#3250] improve(catalog-jdbc-pg): Added missing @OverRide annot…
5837c73 
…ation (apache#3267)

### What changes were proposed in this pull request?

Added `@Override` annotation on getTableBuilder in
PostgreSqlTableOperations

### Why are the changes needed?

Fix: apache#3250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MukarramHaq MukarramHaq

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
3 participants
@justinmclean @jerryshao @MukarramHaq