Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Use ? rather than {0,1} in regex in GravitinoVersion.java #3077

Closed
justinmclean opened this issue Apr 22, 2024 · 0 comments · Fixed by #3147
Closed

[Improvement] Use ? rather than {0,1} in regex in GravitinoVersion.java #3077

justinmclean opened this issue Apr 22, 2024 · 0 comments · Fixed by #3147
Labels
good first issue Good for newcomers improvement Improvements on everything
Milestone
Gravitino June Re...

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Regular expression can be simplified by using "?"

How should we improve?

Simplify regular expression.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Apr 22, 2024
@lw-yang lw-yang mentioned this issue Apr 23, 2024
Merged
@jerryshao jerryshao added this to the Gravitino June Release milestone Apr 24, 2024
@mchades mchades added the 0.5.1 label Apr 26, 2024
mchades pushed a commit that referenced this issue Apr 26, 2024
@lw-yang
[#3077] feat(client): Use ? rather than {0,1} in regex (#3147)
e5c4baf 
### What changes were proposed in this pull request?

Use ? rather than {0,1} in regex in GravitinoVersion.java

### Why are the changes needed?

Fix: #3077 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

exist ut

Co-authored-by: yangliwei <[email protected]>
@mchades mchades added 0.6.0 and removed 0.5.1 labels Apr 29, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@lw-yang @diqiu50
[apache#3077] feat(client): Use ? rather than {0,1} in regex (apache#…
ee14da1 
…3147)

### What changes were proposed in this pull request?

Use ? rather than {0,1} in regex in GravitinoVersion.java

### Why are the changes needed?

Fix: apache#3077 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

exist ut

Co-authored-by: yangliwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
Gravitino June Release
Development

Successfully merging a pull request may close this issue.

[#3077] feat(client): Use ? rather than {0,1} in regex lw-yang/gravitino
3 participants
@justinmclean @jerryshao @mchades