Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Catch Exception instead of Throwable in HiveCatalogOperations.java and HiveClientPool.java #3035

Closed
justinmclean opened this issue Apr 19, 2024 · 1 comment · Fixed by #3041
Closed

[Improvement] Catch Exception instead of Throwable in HiveCatalogOperations.java and HiveClientPool.java #3035

justinmclean opened this issue Apr 19, 2024 · 1 comment · Fixed by #3041
Assignees
@lw-yang
Labels
good first issue Good for newcomers improvement Improvements on everything
Milestone
Gravitino June Re...

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Throwable is the superclass of all errors and exceptions in Java so this will also catch for instance OutOfMemoryError and InternalError which you probably don't want to catch.

How should we improve?

Catch exception instead.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Apr 19, 2024
@lw-yang lw-yang mentioned this issue Apr 19, 2024
Merged
@lw-yang
Copy link
Contributor

lw-yang commented Apr 19, 2024

I've fixed it

@jerryshao jerryshao added this to the Gravitino June Release milestone Apr 24, 2024
mchades pushed a commit that referenced this issue Apr 26, 2024
@lw-yang
[#3035] fix(catalog-hive): catch Exception instead of Throwable (#3041)
5e09e3e 
### What changes were proposed in this pull request?

Catch Exception instead of Throwable in HiveCatalogOperations.java and
HiveClientPool.java

### Why are the changes needed?

Fix: #3035 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

exist ut

Co-authored-by: yangliwei <[email protected]>
@mchades mchades added 0.5.1 and removed 0.5.1 labels Apr 26, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@lw-yang @diqiu50
[apache#3035] fix(catalog-hive): catch Exception instead of Throwable (…
b3e2784 
…apache#3041)

### What changes were proposed in this pull request?

Catch Exception instead of Throwable in HiveCatalogOperations.java and
HiveClientPool.java

### Why are the changes needed?

Fix: apache#3035 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

exist ut

Co-authored-by: yangliwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lw-yang lw-yang

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
Gravitino June Release
Development

Successfully merging a pull request may close this issue.

[#3035] fix(catalog-hive): catch Exception instead of Throwable lw-yang/gravitino
4 participants
@justinmclean @jerryshao @lw-yang @mchades