Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Move assertion functions from AbstractIT to ITUtils for clarity. #2883

Closed
laiyousin opened this issue Apr 11, 2024 · 0 comments · Fixed by #2900
Closed

[Improvement] Move assertion functions from AbstractIT to ITUtils for clarity. #2883

laiyousin opened this issue Apr 11, 2024 · 0 comments · Fixed by #2900
Assignees
@laiyousin
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@laiyousin
Copy link
Contributor

What would you like to be improved?

Currently, the AbstractIT class in the Gravitino project contains two functions, assertionsTableInfo and assertColumn, which are more utility-oriented rather than integral to the abstract test class itself.

How should we improve?

Move the two utility-oriented functions, assertionsTableInfo and assertColumn, from AbstractIT.java to ITUtils.java, and make them public.
Update all references to these functions accordingly.
@laiyousin laiyousin added the improvement Improvements on everything label Apr 11, 2024
laiyousin added a commit to laiyousin/gravitino that referenced this issue Apr 11, 2024
@laiyousin
[apache#2883] Move assertion functions from AbstractIT to ITUtils for…
b8b5f49 
… clarity.
@mchades mchades mentioned this issue Apr 12, 2024
Merged
jerryshao pushed a commit that referenced this issue Apr 15, 2024
@laiyousin
[#2883] refactor(ITUtils): move assertion functions from AbstractIT f…
e946923 
…or clarity (#2900)

### What changes were proposed in this pull request?

Move the two utility-oriented functions, assertionsTableInfo and
assertColumn, from AbstractIT.java to ITUtils.java, and make them
public.
Update all references to these functions accordingly.

### Why are the changes needed?

Currently, the AbstractIT class in the Gravitino project contains two
functions, assertionsTableInfo and assertColumn, which are more
utility-oriented rather than integral to the abstract test class itself.

Fix: #2883

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laiyousin laiyousin

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2883] refactor(ITUtils): move assertion functions from AbstractIT for clarity laiyousin/gravitino
2 participants
@jerryshao @laiyousin