Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Get entity from KV backend missing namespace #2856

Closed
mchades opened this issue Apr 9, 2024 · 0 comments · Fixed by #2971
Closed

[Improvement] Get entity from KV backend missing namespace #2856

mchades opened this issue Apr 9, 2024 · 0 comments · Fixed by #2971
Assignees
@jerryshao
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@mchades
Copy link
Contributor

mchades commented Apr 9, 2024

What would you like to be improved?

The KV store does not serialize or complete the entity namespace when retrieving it. This will result in an empty namespace in CatalogInfo.

How should we improve?

KV store complete the entity namespace
@mchades mchades added the improvement Improvements on everything label Apr 9, 2024
@jerryshao jerryshao mentioned this issue Apr 16, 2024
Merged
mchades pushed a commit that referenced this issue Apr 17, 2024
@jerryshao
[#2856] fix(core): Fix the namespace missing issue when get entities …
e2d1fd0 
…from kv storage (#2971)

### What changes were proposed in this pull request?

This PR fixes the namespace missing issue when entities are gotten from
kv storage.

### Why are the changes needed?

Fix: #2856 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Modified UTs.
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerryshao jerryshao

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
2 participants
@jerryshao @mchades