Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Extend sleep time in the testInternalCache unit test #2745

Closed
xloya opened this issue Apr 1, 2024 · 0 comments · Fixed by #2744
Closed

[Improvement] Extend sleep time in the testInternalCache unit test #2745

xloya opened this issue Apr 1, 2024 · 0 comments · Fixed by #2744
Assignees
@xloya
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@xloya
Copy link
Contributor

xloya commented Apr 1, 2024

What would you like to be improved?

Caffeine Cache's use of RemoveListener is not stable and may cause a single test to fail in some cases.
image

How should we improve?

No response
@xloya xloya added the improvement Improvements on everything label Apr 1, 2024
@xloya xloya mentioned this issue Apr 1, 2024
Merged
jerryshao pushed a commit that referenced this issue Apr 1, 2024
@xloya
[#2745] fix(test): Extend sleep time in the testInternalCache unit …
c433f84 
…test to fix flaky test (#2744)

### What changes were proposed in this pull request?

`Caffeine Cache`'s use of `RemoveListener` is not stable and may cause a
single test to fail in some cases. Therefore, the waiting time in the
single test is extended to ensure that the `Cache` is cleaned normally.


![image](https://github.com/datastrato/gravitino/assets/26177232/7ecb8a6b-28a0-4146-91bd-0e633f9fe53b)

### Why are the changes needed?

Fix: #2745

---------

Co-authored-by: xiaojiebao <[email protected]>
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xloya xloya

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
2 participants
@jerryshao @xloya