Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] [spark-connector] support null type for spark connector #2595

Closed
FANNG1 opened this issue Mar 19, 2024 · 2 comments · Fixed by #2660
Closed

[Improvement] [spark-connector] support null type for spark connector #2595

FANNG1 opened this issue Mar 19, 2024 · 2 comments · Fixed by #2660
Assignees
@charliecheng630
Labels
good first issue Good for newcomers improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 19, 2024

What would you like to be improved?

you could refer #2484 add null type support for spark connector, add transform logic in SparkTypeConverter and add test in TestSparkTypeConverter

How should we improve?

No response
@FANNG1 FANNG1 added improvement Improvements on everything good first issue Good for newcomers labels Mar 19, 2024
@FANNG1 FANNG1 added this to the Gravitino 0.5.0 milestone Mar 19, 2024
@charliecheng630
Copy link
Contributor

I would like to work on this. @FANNG1

@FANNG1
Copy link
Contributor Author

FANNG1 commented Mar 22, 2024

@charliecheng630 thanks for taking this, assigned to you.

@charliecheng630 charliecheng630 mentioned this issue Mar 23, 2024
Merged
FANNG1 pushed a commit that referenced this issue Mar 23, 2024
@charliecheng630
[#2595] feat(spark-connector) support null type for spark connector (#…
b3a3e1b 
…2660)

### What changes were proposed in this pull request?

Support null type for spark-connector; add related test

### Why are the changes needed?

Fix: #2595 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew test -PskipITs`
coolderli pushed a commit to coolderli/gravitino that referenced this issue Apr 2, 2024
@charliecheng630
[apache#2595] feat(spark-connector) support null type for spark conne…
df9cb65 
…ctor (apache#2660)

### What changes were proposed in this pull request?

Support null type for spark-connector; add related test

### Why are the changes needed?

Fix: apache#2595 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew test -PskipITs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliecheng630 charliecheng630

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2595] feat(spark-connector) support null type for spark connector charliecheng630/gravitino
2 participants
@FANNG1 @charliecheng630