Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Refactoring integration tests for spark-connector #2566

Closed
caican00 opened this issue Mar 18, 2024 · 0 comments · Fixed by #2578
Closed

[Improvement] Refactoring integration tests for spark-connector #2566

caican00 opened this issue Mar 18, 2024 · 0 comments · Fixed by #2578
Assignees
Labels
improvement Improvements on everything

Comments

@caican00
Copy link
Collaborator

What would you like to be improved?

Make SparkIT to SparkCommonIT which contains the common tests shared by all catalogs.

Add new SparkHiveCatalogIT to test Hive specific tests and SparkIcebergCatalogIT to test Iceberg specific tests, both SparkXXCatalogIT extends SparkCommonIT.

How should we improve?

No response

@caican00 caican00 added the improvement Improvements on everything label Mar 18, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Mar 18, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Mar 19, 2024
@FANNG1 FANNG1 added this to the Gravitino 0.5.0 milestone Mar 19, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Mar 19, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Mar 19, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Mar 19, 2024
caican00 added a commit to caican00/gravitino that referenced this issue Mar 19, 2024
FANNG1 pushed a commit that referenced this issue Mar 19, 2024
…or spark-connector (#2578)

### What changes were proposed in this pull request?

1. Make SparkIT to SparkCommonIT which contains the common tests shared
by all catalogs.

2. Add new SparkHiveCatalogIT to test Hive specific tests, and both
SparkXXCatalogIT extends SparkCommonIT.

### Why are the changes needed?
Separate integration testing for different data sources.

Fix: #2566

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
 Integration tests after separation.
coolderli pushed a commit to coolderli/gravitino that referenced this issue Apr 2, 2024
…ests for spark-connector (apache#2578)

### What changes were proposed in this pull request?

1. Make SparkIT to SparkCommonIT which contains the common tests shared
by all catalogs.

2. Add new SparkHiveCatalogIT to test Hive specific tests, and both
SparkXXCatalogIT extends SparkCommonIT.

### Why are the changes needed?
Separate integration testing for different data sources.

Fix: apache#2566

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
 Integration tests after separation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
2 participants