-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] use simple catalog name in Trino connector #2433
Comments
Thanks @xiacongling for your valid feedback, we're working on this thing, I think @shaofengshi may have more to tell. |
@xiacongling, @diqiu50 do you want to work on this? |
hi, @shaofengshi, @diqiu50. i'd be happy to contribute. we are trying to make our file based catalogs being managed by gravitino and i'll be working on it in the next few days. |
@xiacongling Ok, Thank you for the contribute. Let's first discuss the solution. |
Well, @diqiu50. The idea is pretty straightforward. Simplify the name when Gravitino invokes Trino's API and canonicalize it when Trino invokes Gravitino.
The metalake name which will be omitted is provided by configuration property Not sure if there's anything else I'm missing here. please point them out. thanks! |
…2547) <!-- 1. Title: [#<issue>] <type>(<scope>): <subject> Examples: - "[#123] feat(operator): support xxx" - "[#233] fix: check null before access result in xxx" - "[MINOR] refactor: fix typo in variable name" - "[MINOR] docs: fix typo in README" - "[#255] test: fix flaky test NameOfTheTest" Reference: https://www.conventionalcommits.org/en/v1.0.0/ 2. If the PR is unfinished, please mark this PR as draft. --> ### What changes were proposed in this pull request? Support omitting metalake prefix for Trino connector. ### Why are the changes needed? Gravitino register a dynamic catalog with name like `some_metalake.some_catalog`. It is long and must be quoted to use. Besides, if one wants to manage file-based catalogs with Gravitino, users need to adjust their SQL for catalog name changing. With this patch, Trino admins can add a Gravitino connector property `gravitino.simplify-catalog-names=true` to keep the catalog name as it is without `some_metalake.` prefix. Fix: #2433 ### Does this PR introduce _any_ user-facing change? No for default settings. If `gravitino.simplify-catalog-names=true` is set, the catalog names will change when using Trino with Gravitino. ### How was this patch tested? UT --------- Co-authored-by: yuhui <[email protected]>
What would you like to be improved?
When using Gravitino Trino connector to access data, user need to use quoted catalog names like
"{metalake}.{catalog}"
. this may lead to compatible problems when migrating file-based catalogs to gravitino metalake. it should keep the original catalog names (usually without{metalake}.
prefix) for Trino.How should we improve?
No response
The text was updated successfully, but these errors were encountered: