Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] [spark-connector] make Spark SQL keyword to upper case #2424

Closed
FANNG1 opened this issue Mar 5, 2024 · 4 comments · Fixed by #2437
Closed

[Improvement] [spark-connector] make Spark SQL keyword to upper case #2424

FANNG1 opened this issue Mar 5, 2024 · 4 comments · Fixed by #2437
Assignees
@ichuniq
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 5, 2024

What would you like to be improved?

spark sql is used in spark connector integrate test, some sqls are lower case like create database db , we'd better unify all Spark KeyWord to upper cases like CREATE DATABASE db

How should we improve?

No response
@FANNG1 FANNG1 added good first issue Good for newcomers improvement Improvements on everything labels Mar 5, 2024
@ichuniq
Copy link
Contributor

ichuniq commented Mar 5, 2024

Hi @FANNG1 I'm new to the community, I would like to work on this!

@FANNG1
Copy link
Contributor Author

FANNG1 commented Mar 5, 2024

Hi @FANNG1 I'm new to the community, I would like to work on this!

thanks for working on this, assigned to you.

@jerryshao
Copy link
Contributor

@FANNG1 I think you'd better adding more information about how and where to fix, to help @ichuniq work on this.

@FANNG1
Copy link
Contributor Author

FANNG1 commented Mar 5, 2024

@ichuniq you could refer SparkIT.java and SparkUtilIT.java

@ichuniq ichuniq mentioned this issue Mar 5, 2024
Merged
FANNG1 pushed a commit that referenced this issue Mar 5, 2024
@ichuniq
[#2424] test(spark-connector): make all Spark SQL keywords uppercase …
ec2fd57 
…for consistency (#2437)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Make all Spark SQL keywords used in spark connector integration test
uppercase

### Why are the changes needed?

Fix: #2424 

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
`./gradlew build -PskipTests`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichuniq ichuniq

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
3 participants
@jerryshao @FANNG1 @ichuniq