[Improvement] In HadoopCatalogOperations.java incorrect use of static field

[justinmclean]

What would you like to be improved?

In HadoopCatalogOperations.java GRAVITINO_MANAGED_ENTITY in not a static field, it belongs to it's parent.

 .put(HadoopSchemaPropertiesMetadata.GRAVITINO_MANAGED_ENTITY, Boolean.TRUE.toString())

How should we improve?

Reference GRAVITINO_MANAGED_ENTITY correctly using the parent class.

[YxAc]

hi @justinmclean , GRAVITINO_MANAGED_ENTITY is a static field of the parent class, and It is legal to access the static member of the parent class through the subclass name. So I think it's not a problem.

[justinmclean]

While this is a minor issue and while It is legal it is not best practice. Static members are associated with the class itself, not with any of its child classes. Accessing it via the wrong method possible suggests a misunderstanding of how OO works. It is best practice to use the base class for clarity.

[YxAc]

While this is a minor issue and while It is legal it is not best practice. Static members are associated with the class itself, not with any of its child classes. Accessing it via the wrong method possible suggests a misunderstanding of how OO works. It is best practice to use the base class for clarity.

Got it and Agree. I'll fix this.