Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] IcebergColumn.java missing equals method #1918

Closed
justinmclean opened this issue Feb 2, 2024 · 0 comments · Fixed by #2351
Closed

[Improvement] IcebergColumn.java missing equals method #1918

justinmclean opened this issue Feb 2, 2024 · 0 comments · Fixed by #2351
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Subclass has equals method.

How should we improve?

add equals method
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Feb 2, 2024
SteNicholas added a commit to SteNicholas/gravitino that referenced this issue Feb 26, 2024
@SteNicholas
[apache#1918] improvement(catalog): Add annotation @EqualsAndHashCode …
c8b9699 
…of IcebergColumn and JdbcColumn
@SteNicholas SteNicholas mentioned this issue Feb 26, 2024
Closed
SteNicholas added a commit to SteNicholas/gravitino that referenced this issue Feb 26, 2024
@SteNicholas
[apache#1918] improvement(catalog): Add annotation @EqualsAndHashCode …
07f07ae 
…of IcebergColumn and JdbcColumn
@SteNicholas SteNicholas mentioned this issue Feb 26, 2024
Merged
SteNicholas added a commit to SteNicholas/gravitino that referenced this issue Feb 27, 2024
@SteNicholas
[apache#1918] improvement(catalog): Add annotation @EqualsAndHashCode …
0d8542a 
…of IcebergColumn and JdbcColumn
SteNicholas added a commit to SteNicholas/gravitino that referenced this issue Feb 27, 2024
@SteNicholas
[apache#1918] improvement(catalog): Add annotation @EqualsAndHashCode …
43e04e2 
…of IcebergColumn and JdbcColumn
jerryshao pushed a commit that referenced this issue Feb 27, 2024
@SteNicholas
[#1918] improvement(catalog): Add annotation @EqualsAndHashCode of …
989ad92 
…`IcebergColumn` and `JdbcColumn` (#2351)

### What changes were proposed in this pull request?

Add annotation `@EqualsAndHashCode` of `IcebergColumn` and `JdbcColumn`.

### Why are the changes needed?

As `HiveColumn` has annotation `@EqualsAndHashCode` to support `equals`
and `hashCode` method at present, `IcebergColumn` and `JdbcColumn` shoud
be added the annotation `@EqualsAndHashCode`.

Fix: #1918

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
1 participant
@justinmclean