Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In HiveCatalogOperations.java it may be better to use java.nio.file.Files#delete #1909

Closed
justinmclean opened this issue Feb 2, 2024 · 3 comments
Closed

[Improvement] In HiveCatalogOperations.java it may be better to use java.nio.file.Files#delete #1909

justinmclean opened this issue Feb 2, 2024 · 3 comments
Assignees
@liujinhui1994
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

When java.nio.file.Files#delete fails, it returns one of a series of exception types to better indicate the cause of the failure.

How should we improve?

Change to use java.nio.file.Files#delete.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Feb 2, 2024
@m1a2st m1a2st mentioned this issue Jun 2, 2024
Closed
@m1a2st
Copy link
Contributor

m1a2st commented Jun 2, 2024

I'm interesting in this issue, my PR is here.

@liujinhui1994
Copy link
Contributor

Please assign it to me, I have completed it

@mchades mchades mentioned this issue Jun 3, 2024
Merged
mchades pushed a commit that referenced this issue Jun 3, 2024
@liujinhui1994
[#1909] Improvement:In HiveCatalogOperations.java it may be better to…
c8dabb7 
… use java.nio.file.Files (#3519)

### What changes were proposed in this pull request?

Change to use java.nio.file.Files#delete.

### Why are the changes needed?

When java.nio.file.Files#delete fails, it returns one of a series of
exception types to better indicate the cause of the failure.
#1909 

### Does this PR introduce _any_ user-facing change?

NO

---------

Co-authored-by: liujh <[email protected]>
@mchades
Copy link
Contributor

mchades commented Jun 3, 2024

Hi, @m1a2st this issue has already been completed by #3519 , you can pick other issues that interest you, thanks for your enthusiasm

@mchades mchades closed this as completed Jun 3, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@liujinhui1994 @diqiu50
[apache#1909] Improvement:In HiveCatalogOperations.java it may be bet…
0359aa4 
…ter to use java.nio.file.Files (apache#3519)

### What changes were proposed in this pull request?

Change to use java.nio.file.Files#delete.

### Why are the changes needed?

When java.nio.file.Files#delete fails, it returns one of a series of
exception types to better indicate the cause of the failure.
apache#1909 

### Does this PR introduce _any_ user-facing change?

NO

---------

Co-authored-by: liujh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liujinhui1994 liujinhui1994

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinmclean @mchades @liujinhui1994 @m1a2st