Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] copyright year in Gravitino UI is incorrect #1299

Closed
justinmclean opened this issue Jan 2, 2024 · 0 comments · Fixed by #1301
Closed

[Improvement] copyright year in Gravitino UI is incorrect #1299

justinmclean opened this issue Jan 2, 2024 · 0 comments · Fixed by #1301
Assignees
Labels
improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

The year of copyright is when the software was published not the current year.

How should we improve?

Don't use new Date().getFullYear() to get the year of copyright in the Gravitino Web UI.

@justinmclean justinmclean added the improvement Improvements on everything label Jan 2, 2024
@justinmclean justinmclean self-assigned this Jan 3, 2024
jerryshao pushed a commit that referenced this issue Jan 3, 2024
### What changes were proposed in this pull request?

Fix the copyright year to be the year of the last release, not the
current year.

### Why are the changes needed?

The copyright year should not automatically update to the current year.

Fix: #1299

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Built and tested locally in a browser.
github-actions bot pushed a commit that referenced this issue Jan 3, 2024
### What changes were proposed in this pull request?

Fix the copyright year to be the year of the last release, not the
current year.

### Why are the changes needed?

The copyright year should not automatically update to the current year.

Fix: #1299

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Built and tested locally in a browser.
jerryshao pushed a commit that referenced this issue Jan 3, 2024
### What changes were proposed in this pull request?

Fix the copyright year to be the year of the last release, not the
current year.

### Why are the changes needed?

The copyright year should not automatically update to the current year.

Fix: #1299

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Built and tested locally in a browser.

Co-authored-by: Justin Mclean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant