[Improvement] After a ./gradlew clean class files still exist

[justinmclean]

What would you like to be improved?

Class files still exist after running ./gradlew clean. You can see this by running this in the gravitino directory.

./gradlew clean
find . -name "*.class" -print

How should we improve?

clean usually cleans up class files

[hiirrxnn]

Could I work on this ?

[justinmclean]

Are you familiar with Gradle? If not it may be best to select something else to work on.

[coolderli]

@justinmclean I try to fix this on #2222. At first, my problem is that there is a bin directory in each subproject directory. But I can't reproduce it when I clean the bin directory manually.
There are still some *.class files in the gradle cache. Should we clean them?
Can you try again whether this issue still exists? Thanks.

~/Project/gravitino (main) » find . -name "*.class" -print                                                                                           dian@local-dian

./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibsInPluginsBlock$JettyLibraryAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibsInPluginsBlock$JerseyContainerLibraryAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$ImmutablesVersionAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$Hadoop2MapreduceClientLibraryAccessors.class

[justinmclean]

I wouldn't worry about the gradle cache

[coolderli]

I wouldn't worry about the gradle cache

@justinmclean
I think this issue can be closed. Because I didn't reproduce it.

[yuqi1129]

@coolderli , There are still some class files except the cache files in my local environment.

[coolderli]

@yuqi1129 Can you tell me when will generate the directory ./*/bin/**? I can't reproduce it when I build the project by ./gradlew clean build -PskipTests -PskipITs. Is it because I skipped integration testing?

[yuqi1129]

@yuqi1129 Can you tell me when will generate the directory ./*/bin/**? I can't reproduce it when I build the project by ./gradlew clean build -PskipTests -PskipITs. Is it because I skipped integration testing?

Can you use the command ./gradlew clean 2>&1 1>/dev/null && ./gradlew build -PskipTests -PskipITs 2>&1 1>/dev/null && ./gradlew clean 2>&1 1>/dev/null && find . -name "*.class" -print to take a retry?

Note: main branch(commit id: c9d9f36)

[coolderli]

@yuqi1129 Here are the logs. There are no other class files. I have dropped all the bin directories manually before.

(base) gravitino (main) » ./gradlew clean 2>&1 1>/dev/null && ./gradlew build -PskipTests -PskipITs 2>&1 1>/dev/null && ./gradlew clean 2>&1 1>/dev/null && find . -name "*.class" -print

注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。

    ╔══════════════════════════════════════════════════════╗
    ║                                                      ║
    ║  A new version of Redocly CLI (1.9.0) is available.  ║
    ║  Update now: `npm i -g @redocly/cli@latest`.         ║
    ║  Changelog: https://redocly.com/docs/cli/changelog/  ║
    ║                                                      ║
    ╚══════════════════════════════════════════════════════╝
  validating /home/mi/IdeaProjects/gravitino/docs/open-api/openapi.yaml...
/home/mi/IdeaProjects/gravitino/docs/open-api/openapi.yaml: validated in 993ms

Woohoo! Your API description is valid. 🎉

注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: /home/mi/IdeaProjects/gravitino/clients/client-java/src/main/java/com/datastrato/gravitino/client/OAuth2TokenProvider.java使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: /home/mi/IdeaProjects/gravitino/clients/client-java/src/test/java/com/datastrato/gravitino/client/TestRelationalCatalog.java使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: /home/mi/IdeaProjects/gravitino/server/src/test/java/com/datastrato/gravitino/server/web/TestVersioningFilter.java使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: /home/mi/IdeaProjects/gravitino/catalogs/catalog-lakehouse-iceberg/src/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/web/metrics/IcebergMetricsManager.java使用了未安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
注: 某些输入文件使用了未经检查或不安全的操作。
注: 有关详细信息, 请使用 -Xlint:unchecked 重新编译。
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$GradleExtensionsVersionAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$VersionAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibsInPluginsBlock$MockserverClientLibraryAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$JlineLibraryAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibsInPluginsBlock$SpotlessVersionAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibsInPluginsBlock$IcebergLibraryAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$NodeVersionAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibs$ScalaCollectionVersionAccessors.class
./.gradle/8.2/dependencies-accessors/d7e72adc4a757cd8d731f2c6f288fdf32db5f9f2/classes/org/gradle/accessors/dm/LibrariesForLibsInPluginsBlock$Log4jSlf4j2LibraryAccessors.class

[yuqi1129]

@coolderli
It's my mistake, I forgot to remove the directory bin manually. The outcome is what you have demonstrated.

[coolderli]

@yuqi1129 #2222 can drop the bin directory. But I can't reproduce it to generate the bin directory. So I just closed it.

[yuqi1129]

@yuqi1129 #2222 can drop the bin directory. But I can't reproduce it to generate the bin directory. So I just closed it.

I believe that since it cannot be reproduced, we can put an end to this issue.

[justinmclean]

Please reopen if the issue happens again.